Merge pull request #3322 from gui217/fix/rnnoise_filter_handle_empty_audio

Fix/rnnoise filter handle empty audio

src/pipecat/audio/filters/rnnoise_filter.py

@@ -115,6 +115,10 @@ class RNNoiseFilter(BaseAudioFilter):
         if self._sample_rate != 48000 and self._resampler_in:
             in_audio = await self._resampler_in.resample(audio, self._sample_rate, 48000)
 
+        # If audio is empty, return empty bytes (no point in noise cancellation)
+        if len(in_audio) == 0:
+            return b""
+
         # Convert bytes to numpy array (int16)
         audio_samples = np.frombuffer(in_audio, dtype=np.int16)
 

tests/test_rnnoise_filter.py

@@ -5,6 +5,7 @@
 #
 
 import unittest
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import numpy as np
 
@@ -100,3 +101,45 @@ class TestRNNoiseFilter(unittest.IsolatedAsyncioTestCase):
         self.assertGreater(len(result2), 0)
 
         await filter.stop()
+
+    async def test_rnnoise_filter_handles_empty_resampler_output(self):
+        """Test that RNNoise filter handles empty bytes from resampler gracefully.
+
+        This reproduces the issue where mute/silence input (like "bx000") causes
+        the resampler to return empty bytes. The filter should handle this gracefully
+        without raising a memory error.
+        """
+        filter = RNNoiseFilter()
+
+        # Initialize with a sample rate that requires resampling (not 48kHz)
+        await filter.start(sample_rate=16000)
+
+        # Enable filtering
+        await filter.process_frame(FilterEnableFrame(enable=True))
+
+        # Create mute/silence audio chunk (like "bx000" - all zeros)
+        # This simulates a mute sound that causes resampler to return empty bytes
+        mute_audio = b"\x00\x00" * 160  # 160 samples of silence at 16kHz (10ms)
+
+        # Mock the resampler to return empty bytes when given mute input
+        # This simulates the behavior where resampler returns b"" for mute sounds
+        async def mock_resample(audio, in_rate, out_rate):
+            # If input is all zeros (mute), return empty bytes
+            # This simulates the real-world scenario where resampler returns b"" for silence
+            audio_data = np.frombuffer(audio, dtype=np.int16)
+            if len(audio_data) == 0 or np.all(audio_data == 0):
+                return b""  # Return empty bytes - this triggers the bug
+            # Otherwise, do normal resampling
+            return audio
+
+        filter._resampler_in.resample = AsyncMock(side_effect=mock_resample)
+
+        result = await filter.filter(mute_audio)
+
+        # When resampler returns empty bytes, filter should return empty bytes
+        # (or handle it gracefully without crashing)
+        self.assertEqual(
+            result, b"", "Filter should return empty bytes when resampler returns empty bytes"
+        )
+
+        await filter.stop()