transports: call parent stop() before disconnecting

This rollbacks a previous change https://github.com/pipecat-ai/pipecat/pull/855
which was trying to fix an issue in the wrong way.

The reasoning behind this fix is that the parent class might be sending audio or
messages (through the subclass) and if we disconnect before all the data is sent
we will run into incomplete audio or even errors. Therefore, we first make sure
the parent tasks stop and then it will be safe to disconnect.

src/pipecat/transports/network/websocket_server.py

@@ -72,14 +72,14 @@ class WebsocketServerInputTransport(BaseInputTransport):
         self._server_task = self.get_event_loop().create_task(self._server_task_handler())
 
     async def stop(self, frame: EndFrame):
+        await super().stop(frame)
         self._stop_server_event.set()
         await self._server_task
-        await super().stop(frame)
 
     async def cancel(self, frame: CancelFrame):
+        await super().cancel(frame)
         self._stop_server_event.set()
         await self._server_task
-        await super().cancel(frame)
 
     async def _server_task_handler(self):
         logger.info(f"Starting websocket server on {self._host}:{self._port}")

src/pipecat/transports/services/daily.py

@@ -694,17 +694,8 @@ class DailyInputTransport(BaseInputTransport):
             self._audio_in_task = self.get_event_loop().create_task(self._audio_in_task_handler())
 
     async def stop(self, frame: EndFrame):
-        # Leave the room.
-        await self._client.leave()
-        # Stop audio thread.
-        if self._audio_in_task and (self._params.audio_in_enabled or self._params.vad_enabled):
-            self._audio_in_task.cancel()
-            await self._audio_in_task
-            self._audio_in_task = None
         # Parent stop.
         await super().stop(frame)
-
-    async def cancel(self, frame: CancelFrame):
         # Leave the room.
         await self._client.leave()
         # Stop audio thread.
@@ -712,8 +703,17 @@ class DailyInputTransport(BaseInputTransport):
             self._audio_in_task.cancel()
             await self._audio_in_task
             self._audio_in_task = None
+
+    async def cancel(self, frame: CancelFrame):
         # Parent stop.
         await super().cancel(frame)
+        # Leave the room.
+        await self._client.leave()
+        # Stop audio thread.
+        if self._audio_in_task and (self._params.audio_in_enabled or self._params.vad_enabled):
+            self._audio_in_task.cancel()
+            await self._audio_in_task
+            self._audio_in_task = None
 
     async def cleanup(self):
         await super().cleanup()
@@ -817,16 +817,16 @@ class DailyOutputTransport(BaseOutputTransport):
         await self._client.join()
 
     async def stop(self, frame: EndFrame):
-        # Leave the room.
-        await self._client.leave()
         # Parent stop.
         await super().stop(frame)
-
-    async def cancel(self, frame: CancelFrame):
         # Leave the room.
         await self._client.leave()
+
+    async def cancel(self, frame: CancelFrame):
         # Parent stop.
         await super().cancel(frame)
+        # Leave the room.
+        await self._client.leave()
 
     async def cleanup(self):
         await super().cleanup()

src/pipecat/transports/services/livekit.py

@@ -323,19 +323,19 @@ class LiveKitInputTransport(BaseInputTransport):
         logger.info("LiveKitInputTransport started")
 
     async def stop(self, frame: EndFrame):
+        await super().stop(frame)
         await self._client.disconnect()
         if self._audio_in_task:
             self._audio_in_task.cancel()
             await self._audio_in_task
-        await super().stop(frame)
         logger.info("LiveKitInputTransport stopped")
 
     async def cancel(self, frame: CancelFrame):
+        await super().cancel(frame)
         await self._client.disconnect()
         if self._audio_in_task and (self._params.audio_in_enabled or self._params.vad_enabled):
             self._audio_in_task.cancel()
             await self._audio_in_task
-        await super().cancel(frame)
 
     def vad_analyzer(self) -> VADAnalyzer | None:
         return self._vad_analyzer
@@ -397,13 +397,13 @@ class LiveKitOutputTransport(BaseOutputTransport):
         logger.info("LiveKitOutputTransport started")
 
     async def stop(self, frame: EndFrame):
-        await self._client.disconnect()
         await super().stop(frame)
+        await self._client.disconnect()
         logger.info("LiveKitOutputTransport stopped")
 
     async def cancel(self, frame: CancelFrame):
-        await self._client.disconnect()
         await super().cancel(frame)
+        await self._client.disconnect()
 
     async def send_message(self, frame: TransportMessageFrame | TransportMessageUrgentFrame):
         if isinstance(frame, (LiveKitTransportMessageFrame, LiveKitTransportMessageUrgentFrame)):