wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3582 from pipecat-ai/aleix/daily-sample-room-url

Browse Source 
rename DAILY_SAMPLE_ROOM_URL to DAILY_ROOM_URL
This commit is contained in:
Aleix Conchillo Flaqué
2026-01-28 10:38:14 -08:00
committed by GitHub
parent 4f08098917 f3ef488925
commit 49bd3da26b
8 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog/3582.change.md Normal file
View File

@@ -0,0 +1 @@
- Pipecat runner now uses `DAILY_ROOM_URL` instead of `DAILY_SAMPLE_ROOM_URL`.

2
env.example
View File

@@ -43,7 +43,7 @@ CEREBRAS_API_KEY=...
# Daily # Daily
DAILY_API_KEY=... DAILY_API_KEY=...
DAILY_SAMPLE_ROOM_URL=https://... DAILY_ROOM_URL=https://...
# Deepgram # Deepgram
DEEPGRAM_API_KEY=... DEEPGRAM_API_KEY=...

2
examples/foundational/37-mem0.py
View File

@@ -31,7 +31,7 @@ Requirements:
- [Optional] Anthropic API key (if using Claude with local config) - [Optional] Anthropic API key (if using Claude with local config)
Environment variables (set in .env or in your terminal using `export`): Environment variables (set in .env or in your terminal using `export`):
DAILY_SAMPLE_ROOM_URL=daily_sample_room_url DAILY_ROOM_URL=daily_room_url
DAILY_API_KEY=daily_api_key DAILY_API_KEY=daily_api_key
OPENAI_API_KEY=openai_api_key OPENAI_API_KEY=openai_api_key
ELEVENLABS_API_KEY=elevenlabs_api_key ELEVENLABS_API_KEY=elevenlabs_api_key

2
examples/foundational/README.md
View File

@@ -37,7 +37,7 @@ Most examples support running with other transports, like Twilio or Daily.
### Daily ### Daily
You need to create a Daily account at https://dashboard.daily.co/u/signup. Once signed up, you can create your own room from the dashboard and set the environment variables `DAILY_SAMPLE_ROOM_URL` and `DAILY_API_KEY`. Alternatively, you can let the example create a room for you (still needs `DAILY_API_KEY` environment variable). Then, start any example with `-t daily`: You need to create a Daily account at https://dashboard.daily.co/u/signup. Once signed up, you can create your own room from the dashboard and set the environment variables `DAILY_ROOM_URL` and `DAILY_API_KEY`. Alternatively, you can let the example create a room for you (still needs `DAILY_API_KEY` environment variable). Then, start any example with `-t daily`:
```bash ```bash
uv run 07-interruptible.py -t daily uv run 07-interruptible.py -t daily

4
scripts/evals/eval.py
View File

@@ -195,7 +195,7 @@ class EvalRunner:
async def run_example_pipeline(script_path: Path, eval_config: EvalConfig): async def run_example_pipeline(script_path: Path, eval_config: EvalConfig):
room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") room_url = os.getenv("DAILY_ROOM_URL")
module = load_module_from_path(script_path) module = load_module_from_path(script_path)
@@ -225,7 +225,7 @@ async def run_eval_pipeline(
): ):
logger.info(f"Starting eval bot") logger.info(f"Starting eval bot")
room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") room_url = os.getenv("DAILY_ROOM_URL")
transport = DailyTransport( transport = DailyTransport(
room_url, room_url,

2
scripts/evals/utils.py
View File

@@ -28,7 +28,7 @@ def check_env_variables() -> bool:
"CARTESIA_API_KEY", "CARTESIA_API_KEY",
"DEEPGRAM_API_KEY", "DEEPGRAM_API_KEY",
"OPENAI_API_KEY", "OPENAI_API_KEY",
"DAILY_SAMPLE_ROOM_URL", "DAILY_ROOM_URL",
] ]
for env in required_envs: for env in required_envs:
if not os.getenv(env): if not os.getenv(env):

6
src/pipecat/runner/daily.py
View File

@@ -17,7 +17,7 @@ Functions:
Environment variables: Environment variables:
- DAILY_API_KEY - Daily API key for room/token creation (required) - DAILY_API_KEY - Daily API key for room/token creation (required)
- DAILY_SAMPLE_ROOM_URL (optional) - Existing room URL to use. If not provided, - DAILY_ROOM_URL (optional) - Existing room URL to use. If not provided,
a temporary room will be created automatically. a temporary room will be created automatically.
Example:: Example::
@@ -91,7 +91,7 @@ async def configure(
"""Configure Daily room URL and token with optional SIP capabilities. """Configure Daily room URL and token with optional SIP capabilities.
This function will either: This function will either:
1. Use an existing room URL from DAILY_SAMPLE_ROOM_URL environment variable (standard mode only) 1. Use an existing room URL from DAILY_ROOM_URL environment variable (standard mode only)
2. Create a new temporary room automatically if no URL is provided 2. Create a new temporary room automatically if no URL is provided
Args: Args:
@@ -177,7 +177,7 @@ async def configure(
) )
# Check for existing room URL (only in standard mode) # Check for existing room URL (only in standard mode)
existing_room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") existing_room_url = os.getenv("DAILY_ROOM_URL")
if existing_room_url and not sip_enabled: if existing_room_url and not sip_enabled:
# Use existing room (standard mode only) # Use existing room (standard mode only)
logger.info(f"Using existing Daily room: {existing_room_url}") logger.info(f"Using existing Daily room: {existing_room_url}")

4
src/pipecat/runner/run.py
View File

@@ -583,13 +583,13 @@ def _setup_daily_routes(app: FastAPI, dialin_enabled: bool = False):
bot_module = _get_bot_module() bot_module = _get_bot_module()
existing_room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") existing_room_url = os.getenv("DAILY_ROOM_URL")
result = None result = None
# Configure room if: # Configure room if:
# 1. Explicitly requested via createDailyRoom in payload # 1. Explicitly requested via createDailyRoom in payload
# 2. Using pre-configured room from DAILY_SAMPLE_ROOM_URL env var # 2. Using pre-configured room from DAILY_ROOM_URL env var
if create_daily_room or existing_room_url: if create_daily_room or existing_room_url:
import aiohttp import aiohttp