From f3ef488925e2687b92a998127a36b6eff9c39102 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Wed, 28 Jan 2026 10:02:25 -0800 Subject: [PATCH] rename DAILY_SAMPLE_ROOM_URL to DAILY_ROOM_URL --- changelog/3582.change.md | 1 + env.example | 2 +- examples/foundational/37-mem0.py | 2 +- examples/foundational/README.md | 2 +- scripts/evals/eval.py | 4 ++-- scripts/evals/utils.py | 2 +- src/pipecat/runner/daily.py | 6 +++--- src/pipecat/runner/run.py | 4 ++-- 8 files changed, 12 insertions(+), 11 deletions(-) create mode 100644 changelog/3582.change.md diff --git a/changelog/3582.change.md b/changelog/3582.change.md new file mode 100644 index 000000000..8581fc6cf --- /dev/null +++ b/changelog/3582.change.md @@ -0,0 +1 @@ +- Pipecat runner now uses `DAILY_ROOM_URL` instead of `DAILY_SAMPLE_ROOM_URL`. diff --git a/env.example b/env.example index c7b734ad6..e662ea54b 100644 --- a/env.example +++ b/env.example @@ -43,7 +43,7 @@ CEREBRAS_API_KEY=... # Daily DAILY_API_KEY=... -DAILY_SAMPLE_ROOM_URL=https://... +DAILY_ROOM_URL=https://... # Deepgram DEEPGRAM_API_KEY=... diff --git a/examples/foundational/37-mem0.py b/examples/foundational/37-mem0.py index 08a739c0a..11eae51fb 100644 --- a/examples/foundational/37-mem0.py +++ b/examples/foundational/37-mem0.py @@ -31,7 +31,7 @@ Requirements: - [Optional] Anthropic API key (if using Claude with local config) Environment variables (set in .env or in your terminal using `export`): - DAILY_SAMPLE_ROOM_URL=daily_sample_room_url + DAILY_ROOM_URL=daily_room_url DAILY_API_KEY=daily_api_key OPENAI_API_KEY=openai_api_key ELEVENLABS_API_KEY=elevenlabs_api_key diff --git a/examples/foundational/README.md b/examples/foundational/README.md index 5800efff3..9947dd1e6 100644 --- a/examples/foundational/README.md +++ b/examples/foundational/README.md @@ -37,7 +37,7 @@ Most examples support running with other transports, like Twilio or Daily. ### Daily -You need to create a Daily account at https://dashboard.daily.co/u/signup. Once signed up, you can create your own room from the dashboard and set the environment variables `DAILY_SAMPLE_ROOM_URL` and `DAILY_API_KEY`. Alternatively, you can let the example create a room for you (still needs `DAILY_API_KEY` environment variable). Then, start any example with `-t daily`: +You need to create a Daily account at https://dashboard.daily.co/u/signup. Once signed up, you can create your own room from the dashboard and set the environment variables `DAILY_ROOM_URL` and `DAILY_API_KEY`. Alternatively, you can let the example create a room for you (still needs `DAILY_API_KEY` environment variable). Then, start any example with `-t daily`: ```bash uv run 07-interruptible.py -t daily diff --git a/scripts/evals/eval.py b/scripts/evals/eval.py index 16598b4d7..20c15c1c9 100644 --- a/scripts/evals/eval.py +++ b/scripts/evals/eval.py @@ -195,7 +195,7 @@ class EvalRunner: async def run_example_pipeline(script_path: Path, eval_config: EvalConfig): - room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") + room_url = os.getenv("DAILY_ROOM_URL") module = load_module_from_path(script_path) @@ -225,7 +225,7 @@ async def run_eval_pipeline( ): logger.info(f"Starting eval bot") - room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") + room_url = os.getenv("DAILY_ROOM_URL") transport = DailyTransport( room_url, diff --git a/scripts/evals/utils.py b/scripts/evals/utils.py index 590cc0946..8111d404f 100644 --- a/scripts/evals/utils.py +++ b/scripts/evals/utils.py @@ -28,7 +28,7 @@ def check_env_variables() -> bool: "CARTESIA_API_KEY", "DEEPGRAM_API_KEY", "OPENAI_API_KEY", - "DAILY_SAMPLE_ROOM_URL", + "DAILY_ROOM_URL", ] for env in required_envs: if not os.getenv(env): diff --git a/src/pipecat/runner/daily.py b/src/pipecat/runner/daily.py index 6747dbd62..b2090b094 100644 --- a/src/pipecat/runner/daily.py +++ b/src/pipecat/runner/daily.py @@ -17,7 +17,7 @@ Functions: Environment variables: - DAILY_API_KEY - Daily API key for room/token creation (required) -- DAILY_SAMPLE_ROOM_URL (optional) - Existing room URL to use. If not provided, +- DAILY_ROOM_URL (optional) - Existing room URL to use. If not provided, a temporary room will be created automatically. Example:: @@ -91,7 +91,7 @@ async def configure( """Configure Daily room URL and token with optional SIP capabilities. This function will either: - 1. Use an existing room URL from DAILY_SAMPLE_ROOM_URL environment variable (standard mode only) + 1. Use an existing room URL from DAILY_ROOM_URL environment variable (standard mode only) 2. Create a new temporary room automatically if no URL is provided Args: @@ -177,7 +177,7 @@ async def configure( ) # Check for existing room URL (only in standard mode) - existing_room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") + existing_room_url = os.getenv("DAILY_ROOM_URL") if existing_room_url and not sip_enabled: # Use existing room (standard mode only) logger.info(f"Using existing Daily room: {existing_room_url}") diff --git a/src/pipecat/runner/run.py b/src/pipecat/runner/run.py index 96fbf2598..6f7f1b53b 100644 --- a/src/pipecat/runner/run.py +++ b/src/pipecat/runner/run.py @@ -583,13 +583,13 @@ def _setup_daily_routes(app: FastAPI, dialin_enabled: bool = False): bot_module = _get_bot_module() - existing_room_url = os.getenv("DAILY_SAMPLE_ROOM_URL") + existing_room_url = os.getenv("DAILY_ROOM_URL") result = None # Configure room if: # 1. Explicitly requested via createDailyRoom in payload - # 2. Using pre-configured room from DAILY_SAMPLE_ROOM_URL env var + # 2. Using pre-configured room from DAILY_ROOM_URL env var if create_daily_room or existing_room_url: import aiohttp