refactor: explicit kind=='final' check in async-tool routing (Grok)

Mirrors the same change applied to AWSNovaSonicLLMService and
OpenAIRealtimeLLMService in #4441: replaces the implicit "final happens
last" pattern in _process_completed_function_calls with an explicit
`if async_payload.kind == "final":` block, plus a trailing defensive
`continue` so async-tool messages with an unrecognized kind don't fall
through to the regular tool-result handling block.
This commit is contained in:
Paul Kompfner
2026-05-08 15:45:05 -04:00
parent b14a03d01f
commit 2c65713c99

View File

@@ -942,12 +942,19 @@ class GrokRealtimeLLMService(LLMService[GrokRealtimeLLMAdapter]):
error_msg="Grok Realtime does not support streamed async tool results.",
)
continue
# kind == "final": deliver via the formal tool-result channel
# — same path as a synchronous tool result, just delayed.
if send_new_results:
sent_new_result = True
await self._send_tool_result(async_payload.tool_call_id, async_payload.result)
self._completed_tool_calls.add(async_payload.tool_call_id)
if async_payload.kind == "final":
# Deliver via the formal tool-result channel — same path
# as a synchronous tool result, just delayed.
if send_new_results:
sent_new_result = True
await self._send_tool_result(
async_payload.tool_call_id, async_payload.result
)
self._completed_tool_calls.add(async_payload.tool_call_id)
continue
# Defensive: any async-tool message must not fall through
# to the regular tool-result block below, even if it
# carries a kind we don't recognize.
continue
# Look for newly-completed "regular" (as opposed to async-tool) results