Add missing step 3 comment to LLM service init methods

Adds the explicit "no params object" step 3 comment to all
LLM services that skip from step 2 to step 4 in their
settings initialization sequence, matching the pattern
established in services that do have a params object.
This commit is contained in:
Paul Kompfner
2026-03-06 17:01:29 -05:00
parent f630d79900
commit 256c8f87b4
16 changed files with 32 additions and 0 deletions

View File

@@ -64,6 +64,8 @@ class AzureLLMService(OpenAILLMService):
_warn_deprecated_param("model", AzureLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -64,6 +64,8 @@ class CerebrasLLMService(OpenAILLMService):
_warn_deprecated_param("model", CerebrasLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -64,6 +64,8 @@ class DeepSeekLLMService(OpenAILLMService):
_warn_deprecated_param("model", DeepSeekLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -64,6 +64,8 @@ class FireworksLLMService(OpenAILLMService):
_warn_deprecated_param("model", FireworksLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -102,6 +102,8 @@ class GoogleLLMOpenAIBetaService(OpenAILLMService):
_warn_deprecated_param("model", GoogleOpenAILLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -119,6 +119,8 @@ class GrokLLMService(OpenAILLMService):
_warn_deprecated_param("model", GrokLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -63,6 +63,8 @@ class GroqLLMService(OpenAILLMService):
_warn_deprecated_param("model", GroqLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -66,6 +66,8 @@ class MistralLLMService(OpenAILLMService):
_warn_deprecated_param("model", MistralLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -70,6 +70,8 @@ class NvidiaLLMService(OpenAILLMService):
_warn_deprecated_param("model", NvidiaLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -62,6 +62,8 @@ class OLLamaLLMService(OpenAILLMService):
_warn_deprecated_param("model", OllamaLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -82,6 +82,8 @@ class OpenPipeLLMService(OpenAILLMService):
_warn_deprecated_param("model", OpenPipeLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -68,6 +68,8 @@ class OpenRouterLLMService(OpenAILLMService):
_warn_deprecated_param("model", OpenRouterLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -71,6 +71,8 @@ class PerplexityLLMService(OpenAILLMService):
_warn_deprecated_param("model", PerplexityLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -63,6 +63,8 @@ class QwenLLMService(OpenAILLMService):
_warn_deprecated_param("model", QwenLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -75,6 +75,8 @@ class SambaNovaLLMService(OpenAILLMService): # type: ignore
_warn_deprecated_param("model", SambaNovaLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)

View File

@@ -63,6 +63,8 @@ class TogetherLLMService(OpenAILLMService):
_warn_deprecated_param("model", TogetherLLMSettings, "model")
default_settings.model = model
# 3. (No step 3, as there's no params object to apply)
# 4. Apply settings delta (canonical API, always wins)
if settings is not None:
default_settings.apply_update(settings)