wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3979 from pipecat-ai/aleix/daily-optional-transcription-settings

Browse Source 
Clean up start_transcription to use its settings parameter
This commit is contained in:
Aleix Conchillo Flaqué
2026-03-10 12:51:31 -07:00
committed by GitHub
parent 80bd935c19 11a0c11050
commit ed5b061716
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/pipecat/transports/daily/transport.py
View File

@@ -1134,10 +1134,7 @@ class DailyTransportClient(EventHandler):
return "Transcription can't be started without a room token" return "Transcription can't be started without a room token"
future = self._get_event_loop().create_future() future = self._get_event_loop().create_future()
self._client.start_transcription( self._client.start_transcription(settings=settings, completion=completion_callback(future))
settings=self._params.transcription_settings.model_dump(exclude_none=True),
completion=completion_callback(future),
)
return await future return await future
async def stop_transcription(self) -> Optional[CallClientError]: async def stop_transcription(self) -> Optional[CallClientError]:
@@ -2727,7 +2724,8 @@ class DailyTransport(BaseTransport):
if self._params.transcription_enabled: if self._params.transcription_enabled:
# We report an error because we are starting transcription # We report an error because we are starting transcription
# internally and if it fails we need to know. # internally and if it fails we need to know.
error = await self.start_transcription(self._params.transcription_settings) settings = self._params.transcription_settings.model_dump(exclude_none=True)
error = await self.start_transcription(settings)
if error: if error:
await self._on_error(f"Unable to start transcription: {error}") await self._on_error(f"Unable to start transcription: {error}")
await self._call_event_handler("on_joined", data) await self._call_event_handler("on_joined", data)