wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3241 from pipecat-ai/aleix/evals-remove-idle-timeout

Browse Source 
evals remove idle timeout and prompt improvements
This commit is contained in:
Aleix Conchillo Flaqué
2025-12-16 18:04:52 -08:00
committed by GitHub
parent 2bb6ba59fc db983cb693
commit ecd9ec4ad2
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/evals/eval.py
View File

@@ -290,9 +290,9 @@ async def run_eval_pipeline(
"Ignore greetings, comments, non-answers, or requests for clarification." "Ignore greetings, comments, non-answers, or requests for clarification."
) )
if eval_config.eval_speaks_first: if eval_config.eval_speaks_first:
system_prompt = f"You are an evaluation agent, be extremly brief. You will start the conversation by saying: '{example_prompt}'. {common_system_prompt}" system_prompt = f"You are an evaluation agent, be extremly brief. Numerical word answers are allowed. You will start the conversation by saying: '{example_prompt}'. {common_system_prompt}"
else: else:
system_prompt = f"You are an evaluation agent, be extremly brief. First, ask one question: {example_prompt}. {common_system_prompt}" system_prompt = f"You are an evaluation agent, be extremly brief. Numerical word answers are allowed. First, ask one question: {example_prompt}. {common_system_prompt}"
messages = [ messages = [
{ {
@@ -358,10 +358,6 @@ async def run_eval_pipeline(
logger.info(f"Client disconnected") logger.info(f"Client disconnected")
await task.cancel() await task.cancel()
@task.event_handler("on_idle_timeout")
async def on_pipeline_idle_timeout(task):
await eval_runner.assert_eval(False)
@task.event_handler("on_pipeline_finished") @task.event_handler("on_pipeline_finished")
async def on_pipeline_finished(task, frame): async def on_pipeline_finished(task, frame):
if isinstance(frame, EndFrame): if isinstance(frame, EndFrame):

2
scripts/evals/run-release-evals.py
View File

@@ -30,7 +30,7 @@ EVAL_SIMPLE_MATH = EvalConfig(
) )
EVAL_WEATHER = EvalConfig( EVAL_WEATHER = EvalConfig(
prompt="What's the weather in San Francisco? Temperature should be in any unit, just pick one.", prompt="What's the weather in San Francisco? Temperature should be in fahrenheits.",
eval="The user talks about the weather in San Francisco, including the degrees.", eval="The user talks about the weather in San Francisco, including the degrees.",
) )

7
src/pipecat/utils/base_object.py
View File

@@ -13,6 +13,7 @@ and async cleanup for all Pipecat components.
import asyncio import asyncio
import inspect import inspect
import traceback
from abc import ABC from abc import ABC
from dataclasses import dataclass from dataclasses import dataclass
from typing import Any, Dict, List, Optional from typing import Any, Dict, List, Optional
@@ -187,7 +188,11 @@ class BaseObject(ABC):
else: else:
handler(self, *args, **kwargs) handler(self, *args, **kwargs)
except Exception as e: except Exception as e:
logger.error(f"Exception in event handler {event_name}: {e}") tb = traceback.extract_tb(e.__traceback__)
last = tb[-1]
logger.error(
f"Uncaught exception in event handler '{event_name}' ({last.filename}:{last.lineno}): {e}"
)
def _event_task_finished(self, task: asyncio.Task): def _event_task_finished(self, task: asyncio.Task):
"""Clean up completed event handler tasks. """Clean up completed event handler tasks.