wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up test comments after rnnoise filter fix

Browse Source
This commit is contained in:
gui217
2025-12-30 13:35:13 +02:00
parent bad8f8aa51
commit ec5fb392c4
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test_rnnoise_filter.py
View File

@@ -108,10 +108,6 @@ class TestRNNoiseFilter(unittest.IsolatedAsyncioTestCase):
This reproduces the issue where mute/silence input (like "bx000") causes This reproduces the issue where mute/silence input (like "bx000") causes
the resampler to return empty bytes. The filter should handle this gracefully the resampler to return empty bytes. The filter should handle this gracefully
without raising a memory error. without raising a memory error.
Currently this test FAILS because the code raises MemoryError when empty bytes
are passed to denoise_chunk. After fixing the code to check for empty bytes
before calling denoise_chunk, this test should PASS.
""" """
filter = RNNoiseFilter() filter = RNNoiseFilter()
@@ -137,14 +133,7 @@ class TestRNNoiseFilter(unittest.IsolatedAsyncioTestCase):
return audio return audio
filter._resampler_in.resample = AsyncMock(side_effect=mock_resample) filter._resampler_in.resample = AsyncMock(side_effect=mock_resample)
# Don't mock denoise_chunk - let it use the real pyrnnoise library
# Currently this will raise MemoryError when empty bytes are passed
# After the fix, this should return empty bytes gracefully
# The filter should handle empty bytes gracefully without raising an error
# Currently this will FAIL because the code raises MemoryError
# After fixing, this should PASS
result = await filter.filter(mute_audio) result = await filter.filter(mute_audio)
# When resampler returns empty bytes, filter should return empty bytes # When resampler returns empty bytes, filter should return empty bytes