wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

don't use memoryview for concurrency safety.

Browse Source 
Snapshot the blocks into immutable bytes and trim the buffer BEFORE any await, so no memoryview is
held across async yield points. Without this, a concurrent filter() or stop() call could try to
extend() or clear() the bytearray while a memoryview still exports it, raising "Existing exports
of data: object cannot be re-sized".
This commit is contained in:
Gökmen Görgen
2026-03-02 10:55:25 +01:00
parent 16c676a921
commit ea59695551
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/pipecat/audio/filters/aic_filter.py
View File

@@ -458,13 +458,16 @@ class AICFilter(BaseAudioFilter):
if num_blocks == 0: if num_blocks == 0:
return b"" return b""
filtered_chunks: List[bytes] = []
mv = memoryview(self._audio_buffer)
block_size = self._frames_per_block * self._bytes_per_sample block_size = self._frames_per_block * self._bytes_per_sample
total_size = num_blocks * block_size
blocks_data = bytes(self._audio_buffer[:total_size])
self._audio_buffer = self._audio_buffer[total_size:]
filtered_chunks: List[bytes] = []
for i in range(num_blocks): for i in range(num_blocks):
start = i * block_size start = i * block_size
block_i16 = np.frombuffer(mv[start : start + block_size], dtype=self._dtype) block_i16 = np.frombuffer(blocks_data[start : start + block_size], dtype=self._dtype)
# Reuse input buffer, in-place divide # Reuse input buffer, in-place divide
np.copyto(self._in_f32[0], block_i16) np.copyto(self._in_f32[0], block_i16)
@@ -479,5 +482,4 @@ class AICFilter(BaseAudioFilter):
filtered_chunks.append(self._out_i16.tobytes()) filtered_chunks.append(self._out_i16.tobytes())
self._audio_buffer = self._audio_buffer[num_blocks * block_size :]
return b"".join(filtered_chunks) return b"".join(filtered_chunks)