From a362ca4d3df468dbd28a96d2389264331efbcb95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Fri, 5 Apr 2024 19:44:25 -0700 Subject: [PATCH 1/2] transport: increase daily maxFramerate to 30 --- src/dailyai/transports/daily_transport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dailyai/transports/daily_transport.py b/src/dailyai/transports/daily_transport.py index 50a2af124..6ca1dd2b2 100644 --- a/src/dailyai/transports/daily_transport.py +++ b/src/dailyai/transports/daily_transport.py @@ -224,7 +224,7 @@ class DailyTransport(ThreadedTransport, EventHandler): "low": { "maxBitrate": 250000, "scaleResolutionDownBy": 1.333, - "maxFramerate": 8, + "maxFramerate": 30, } }, } From 0fd323714ee2f045ad2ba20e0808b59969c7ee55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Fri, 5 Apr 2024 19:55:06 -0700 Subject: [PATCH 2/2] transport: add camera_max_bitrate argument --- src/dailyai/transports/abstract_transport.py | 1 + src/dailyai/transports/daily_transport.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/dailyai/transports/abstract_transport.py b/src/dailyai/transports/abstract_transport.py index f5ecc5880..21e6c02a2 100644 --- a/src/dailyai/transports/abstract_transport.py +++ b/src/dailyai/transports/abstract_transport.py @@ -21,6 +21,7 @@ class AbstractTransport: self._camera_enabled = kwargs.get("camera_enabled") or False self._camera_width = kwargs.get("camera_width") or 1024 self._camera_height = kwargs.get("camera_height") or 768 + self._camera_max_bitrate = kwargs.get("camera_max_bitrate") or 250000 self._speaker_enabled = kwargs.get("speaker_enabled") or False self._speaker_sample_rate = kwargs.get("speaker_sample_rate") or 16000 self._fps = kwargs.get("fps") or 8 diff --git a/src/dailyai/transports/daily_transport.py b/src/dailyai/transports/daily_transport.py index 6ca1dd2b2..236df5773 100644 --- a/src/dailyai/transports/daily_transport.py +++ b/src/dailyai/transports/daily_transport.py @@ -222,7 +222,7 @@ class DailyTransport(ThreadedTransport, EventHandler): "maxQuality": "low", "encodings": { "low": { - "maxBitrate": 250000, + "maxBitrate": self._camera_max_bitrate, "scaleResolutionDownBy": 1.333, "maxFramerate": 30, }