From 1fe4538982e0cafa03bbb576f5212f98d62f8ee7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Wed, 11 Feb 2026 09:51:10 -0800 Subject: [PATCH 1/2] Update PR submission instructions in CLAUDE.md Expand the Pull Requests section with detailed step-by-step instructions including branch naming, commit guidance, changelog generation, and PR description updates. --- CLAUDE.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CLAUDE.md b/CLAUDE.md index cf4c5baec..0f4b55e22 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -155,4 +155,9 @@ Test utilities live in `src/pipecat/tests/utils.py`. Use `run_test()` to send fr ## Pull Requests -After creating a PR, use `/changelog ` to generate the changelog file and `/pr-description ` to update the PR description. +To submit a PR you should: + +1. Create a new branch. Ask the user if they want a specific prefix for the branch name. +2. Commit the changes using multiple commits if the changes are unrelated. +3. After creating the PR, use `/changelog ` to generate the changelog files, commit and push them. +4. Use `/pr-description ` to update the PR description. From a80919ceff4a26c2b65a545996f282e5c853300b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Wed, 11 Feb 2026 09:54:39 -0800 Subject: [PATCH 2/2] Move PR submission instructions from CLAUDE.md to /pr-submit skill Extract the procedural PR workflow into an actionable skill that can be invoked with /pr-submit. CLAUDE.md is better suited for project context and conventions, not step-by-step procedures. --- .claude/skills/pr-submit/SKILL.md | 28 ++++++++++++++++++++++++++++ CLAUDE.md | 8 -------- 2 files changed, 28 insertions(+), 8 deletions(-) create mode 100644 .claude/skills/pr-submit/SKILL.md diff --git a/.claude/skills/pr-submit/SKILL.md b/.claude/skills/pr-submit/SKILL.md new file mode 100644 index 000000000..5724ddb6e --- /dev/null +++ b/.claude/skills/pr-submit/SKILL.md @@ -0,0 +1,28 @@ +--- +name: pr-submit +description: Create and submit a GitHub PR from the current branch +--- + +Submit the current changes as a GitHub pull request. + +## Instructions + +1. Check the current state of the repository: + - Run `git status` to see staged, unstaged, and untracked changes + - Run `git diff` to see current changes + - Run `git log --oneline -10` to see recent commits + +2. If there are uncommitted changes relevant to the PR: + - Ask the user if they want a specific prefix for the branch name (e.g., `alice/`, `fix/`, `feat/`) + - Create a new branch based on the current branch + - Commit the changes using multiple commits if the changes are unrelated + +3. Push the branch and create the PR: + - Push with `-u` flag to set upstream tracking + - Create the PR using `gh pr create` + +4. After the PR is created: + - Run `/changelog ` to generate changelog files, then commit and push them + - Run `/pr-description ` to update the PR description + +5. Return the PR URL to the user. diff --git a/CLAUDE.md b/CLAUDE.md index 0f4b55e22..7b79fa168 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -153,11 +153,3 @@ When adding a new service: Test utilities live in `src/pipecat/tests/utils.py`. Use `run_test()` to send frames through a pipeline and assert expected output frames in each direction. Use `SleepFrame(sleep=N)` to add delays between frames. -## Pull Requests - -To submit a PR you should: - -1. Create a new branch. Ask the user if they want a specific prefix for the branch name. -2. Commit the changes using multiple commits if the changes are unrelated. -3. After creating the PR, use `/changelog ` to generate the changelog files, commit and push them. -4. Use `/pr-description ` to update the PR description.