wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: clean up configure() type hints, deduplicate token expiry, and improve comment

Browse Source 
Narrow misleading Optional type hints on parameters that never accept
None, extract the duplicated token_exp_duration * 60 * 60 calculation,
remove unnecessary forward-reference quotes on DailyMeetingTokenProperties,
and clarify why enable_dialout is explicitly set to False.
This commit is contained in:
Mark Backman
2026-03-17 08:54:07 -04:00
parent 7e60320a74
commit e11b486312
2 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog/4048.changed.md Normal file
View File

@@ -0,0 +1 @@
- Narrowed misleading `Optional` type hints and deduplicated token expiry calculation in `configure()` (`pipecat.runner.daily`).

23
src/pipecat/runner/daily.py
View File

@@ -79,16 +79,16 @@ async def configure(
aiohttp_session: aiohttp.ClientSession, aiohttp_session: aiohttp.ClientSession,
*, *,
api_key: Optional[str] = None, api_key: Optional[str] = None,
room_exp_duration: Optional[float] = 2.0, room_exp_duration: float = 2.0,
token_exp_duration: Optional[float] = 2.0, token_exp_duration: float = 2.0,
sip_caller_phone: Optional[str] = None, sip_caller_phone: Optional[str] = None,
sip_enable_video: Optional[bool] = False, sip_enable_video: bool = False,
sip_num_endpoints: Optional[int] = 1, sip_num_endpoints: int = 1,
sip_codecs: Optional[Dict[str, List[str]]] = None, sip_codecs: Optional[Dict[str, List[str]]] = None,
sip_provider: Optional[str] = None, sip_provider: Optional[str] = None,
room_geo: Optional[str] = None, room_geo: Optional[str] = None,
room_properties: Optional[DailyRoomProperties] = None, room_properties: Optional[DailyRoomProperties] = None,
token_properties: Optional["DailyMeetingTokenProperties"] = None, token_properties: Optional[DailyMeetingTokenProperties] = None,
) -> DailyRoomConfig: ) -> DailyRoomConfig:
"""Configure Daily room URL and token with optional SIP capabilities. """Configure Daily room URL and token with optional SIP capabilities.
@@ -184,6 +184,8 @@ async def configure(
aiohttp_session=aiohttp_session, aiohttp_session=aiohttp_session,
) )
token_expiry_seconds: float = token_exp_duration * 60 * 60
# Check for existing room URL (only in standard mode) # Check for existing room URL (only in standard mode)
existing_room_url = os.getenv("DAILY_ROOM_URL") existing_room_url = os.getenv("DAILY_ROOM_URL")
if existing_room_url and not sip_enabled: if existing_room_url and not sip_enabled:
@@ -192,11 +194,12 @@ async def configure(
room_url = existing_room_url room_url = existing_room_url
# Create token and return standard format # Create token and return standard format
expiry_time: float = token_exp_duration * 60 * 60
token_params = None token_params = None
if token_properties: if token_properties:
token_params = DailyMeetingTokenParams(properties=token_properties) token_params = DailyMeetingTokenParams(properties=token_properties)
token = await daily_rest_helper.get_token(room_url, expiry_time, params=token_params) token = await daily_rest_helper.get_token(
room_url, token_expiry_seconds, params=token_params
)
return DailyRoomConfig(room_url=room_url, token=token) return DailyRoomConfig(room_url=room_url, token=token)
# Create a new room # Create a new room
@@ -229,7 +232,10 @@ async def configure(
provider=sip_provider, provider=sip_provider,
) )
room_properties.sip = sip_params room_properties.sip = sip_params
room_properties.enable_dialout = False # Requires dialout entitlement on Daily plan # Explicitly disable dialout to prevent room creation failures on
# accounts where dialout defaults to enabled but the plan lacks the
# required dialout entitlement.
room_properties.enable_dialout = False
room_properties.start_video_off = not sip_enable_video # Voice-only by default room_properties.start_video_off = not sip_enable_video # Voice-only by default
# Create room parameters # Create room parameters
@@ -241,7 +247,6 @@ async def configure(
logger.info(f"Created Daily room: {room_url}") logger.info(f"Created Daily room: {room_url}")
# Create meeting token # Create meeting token
token_expiry_seconds = token_exp_duration * 60 * 60
token_params = None token_params = None
if token_properties: if token_properties:
token_params = DailyMeetingTokenParams(properties=token_properties) token_params = DailyMeetingTokenParams(properties=token_properties)