DailyTransport: don't timeout prematurely on leave
This commit is contained in:
@@ -17,7 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
|
|
||||||
- Fixed an issue where `DailyTransport` would timeout prematurely on join.
|
- Fixed an issue where `DailyTransport` would timeout prematurely on join and on
|
||||||
|
leave.
|
||||||
|
|
||||||
- Fixed an issue in the runner where starting a DailyTransport room via
|
- Fixed an issue in the runner where starting a DailyTransport room via
|
||||||
`/start` didn't support using the `DAILY_SAMPLE_ROOM_URL` env var.
|
`/start` didn't support using the `DAILY_SAMPLE_ROOM_URL` env var.
|
||||||
|
|||||||
@@ -849,17 +849,12 @@ class DailyTransportClient(EventHandler):
|
|||||||
for track_name, _ in self._custom_audio_tracks.items():
|
for track_name, _ in self._custom_audio_tracks.items():
|
||||||
await self.remove_custom_audio_track(track_name)
|
await self.remove_custom_audio_track(track_name)
|
||||||
|
|
||||||
try:
|
error = await self._leave()
|
||||||
error = await self._leave()
|
if not error:
|
||||||
if not error:
|
logger.info(f"Left {self._room_url}")
|
||||||
logger.info(f"Left {self._room_url}")
|
await self._callbacks.on_left()
|
||||||
await self._callbacks.on_left()
|
else:
|
||||||
else:
|
error_msg = f"Error leaving {self._room_url}: {error}"
|
||||||
error_msg = f"Error leaving {self._room_url}: {error}"
|
|
||||||
logger.error(error_msg)
|
|
||||||
await self._callbacks.on_error(error_msg)
|
|
||||||
except asyncio.TimeoutError:
|
|
||||||
error_msg = f"Time out leaving {self._room_url}"
|
|
||||||
logger.error(error_msg)
|
logger.error(error_msg)
|
||||||
await self._callbacks.on_error(error_msg)
|
await self._callbacks.on_error(error_msg)
|
||||||
|
|
||||||
@@ -870,7 +865,7 @@ class DailyTransportClient(EventHandler):
|
|||||||
|
|
||||||
future = self._get_event_loop().create_future()
|
future = self._get_event_loop().create_future()
|
||||||
self._client.leave(completion=completion_callback(future))
|
self._client.leave(completion=completion_callback(future))
|
||||||
return await asyncio.wait_for(future, timeout=10)
|
return await future
|
||||||
|
|
||||||
def _cleanup(self):
|
def _cleanup(self):
|
||||||
"""Cleanup the Daily client instance."""
|
"""Cleanup the Daily client instance."""
|
||||||
|
|||||||
Reference in New Issue
Block a user