wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PipelineTask: always try to cancel things

Browse Source 
In a previous commit we only cleanup things if the user run
`task.cancel()`. However, if the task finishes cleanly we were not cancelling
anything.
This commit is contained in:
Aleix Conchillo Flaqué
2025-08-05 16:17:03 -07:00
parent de2ae9a2ec
commit d22d2da03d
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/pipecat/pipeline/task.py
View File

@@ -459,20 +459,10 @@ class PipelineTask(BasePipelineTask):
# awaiting a task. # awaiting a task.
pass pass
finally: finally:
# We only cancel things cleanly if we know we are the ones await self._cancel_tasks()
# cancelling. It's possibe that we get an asyncio.CancelledError await self._cleanup(cleanup_pipeline)
# from the outside, in which case it is very likely other tasks have if self._check_dangling_tasks:
# been already cancelled (e.g. when python is shutting down) so we self._print_dangling_tasks()
# can't assume things are being cancelled nicely.
if self._cancelled:
await self._cancel_tasks()
await self._cleanup(cleanup_pipeline)
if self._check_dangling_tasks:
self._print_dangling_tasks()
else:
logger.warning(
f"Pipeline task {self} is not being cancelled properly (use cancel() method)"
)
self._finished = True self._finished = True
async def queue_frame(self, frame: Frame): async def queue_frame(self, frame: Frame):