wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Updated SmallWebRTCTransport to align with how other transports handle on_client_disconnected

Browse Source
This commit is contained in:
Filipi Fuchter
2025-05-27 15:14:44 -03:00
committed by Aleix Conchillo Flaqué
parent 6393e89022
commit bf31bce440
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@@ -89,6 +89,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- ⚠️ Updated `SmallWebRTCTransport` to align with how other transports handle
`on_client_disconnected`. Now, when the connection is closed and no reconnection
is attempted, `on_client_disconnected` is called instead of `on_client_close`. The
`on_client_close` callback is no longer used, use `on_client_disconnected` instead.
- Check if `PipelineTask` has already been cancelled. - Check if `PipelineTask` has already been cancelled.
- Don't raise an exception if event handler is not registered. - Don't raise an exception if event handler is not registered.

15
src/pipecat/transports/network/small_webrtc.py
View File

@@ -50,7 +50,6 @@ class SmallWebRTCCallbacks(BaseModel):
on_app_message: Callable[[Any], Awaitable[None]] on_app_message: Callable[[Any], Awaitable[None]]
on_client_connected: Callable[[SmallWebRTCConnection], Awaitable[None]] on_client_connected: Callable[[SmallWebRTCConnection], Awaitable[None]]
on_client_disconnected: Callable[[SmallWebRTCConnection], Awaitable[None]] on_client_disconnected: Callable[[SmallWebRTCConnection], Awaitable[None]]
on_client_closed: Callable[[SmallWebRTCConnection], Awaitable[None]]
class RawAudioTrack(AudioStreamTrack): class RawAudioTrack(AudioStreamTrack):
@@ -169,7 +168,7 @@ class SmallWebRTCClient:
@self._webrtc_connection.event_handler("disconnected") @self._webrtc_connection.event_handler("disconnected")
async def on_disconnected(connection: SmallWebRTCConnection): async def on_disconnected(connection: SmallWebRTCConnection):
logger.debug("Peer connection lost.") logger.debug("Peer connection lost.")
await self._handle_client_disconnected() await self._handle_peer_disconnected()
@self._webrtc_connection.event_handler("closed") @self._webrtc_connection.event_handler("closed")
async def on_closed(connection: SmallWebRTCConnection): async def on_closed(connection: SmallWebRTCConnection):
@@ -313,7 +312,7 @@ class SmallWebRTCClient:
logger.info(f"Disconnecting to Small WebRTC") logger.info(f"Disconnecting to Small WebRTC")
self._closing = True self._closing = True
await self._webrtc_connection.disconnect() await self._webrtc_connection.disconnect()
await self._handle_client_disconnected() await self._handle_peer_disconnected()
async def send_message(self, frame: TransportMessageFrame | TransportMessageUrgentFrame): async def send_message(self, frame: TransportMessageFrame | TransportMessageUrgentFrame):
if self._can_send(): if self._can_send():
@@ -338,19 +337,18 @@ class SmallWebRTCClient:
await self._callbacks.on_client_connected(self._webrtc_connection) await self._callbacks.on_client_connected(self._webrtc_connection)
async def _handle_client_disconnected(self): async def _handle_peer_disconnected(self):
self._audio_input_track = None self._audio_input_track = None
self._video_input_track = None self._video_input_track = None
self._audio_output_track = None self._audio_output_track = None
self._video_output_track = None self._video_output_track = None
await self._callbacks.on_client_disconnected(self._webrtc_connection)
async def _handle_client_closed(self): async def _handle_client_closed(self):
self._audio_input_track = None self._audio_input_track = None
self._video_input_track = None self._video_input_track = None
self._audio_output_track = None self._audio_output_track = None
self._video_output_track = None self._video_output_track = None
await self._callbacks.on_client_closed(self._webrtc_connection) await self._callbacks.on_client_disconnected(self._webrtc_connection)
async def _handle_app_message(self, message: Any): async def _handle_app_message(self, message: Any):
await self._callbacks.on_app_message(message) await self._callbacks.on_app_message(message)
@@ -525,7 +523,6 @@ class SmallWebRTCTransport(BaseTransport):
on_app_message=self._on_app_message, on_app_message=self._on_app_message,
on_client_connected=self._on_client_connected, on_client_connected=self._on_client_connected,
on_client_disconnected=self._on_client_disconnected, on_client_disconnected=self._on_client_disconnected,
on_client_closed=self._on_client_closed,
) )
self._client = SmallWebRTCClient(webrtc_connection, self._callbacks) self._client = SmallWebRTCClient(webrtc_connection, self._callbacks)
@@ -538,7 +535,6 @@ class SmallWebRTCTransport(BaseTransport):
self._register_event_handler("on_app_message") self._register_event_handler("on_app_message")
self._register_event_handler("on_client_connected") self._register_event_handler("on_client_connected")
self._register_event_handler("on_client_disconnected") self._register_event_handler("on_client_disconnected")
self._register_event_handler("on_client_closed")
def input(self) -> SmallWebRTCInputTransport: def input(self) -> SmallWebRTCInputTransport:
if not self._input: if not self._input:
@@ -572,6 +568,3 @@ class SmallWebRTCTransport(BaseTransport):
async def _on_client_disconnected(self, webrtc_connection): async def _on_client_disconnected(self, webrtc_connection):
await self._call_event_handler("on_client_disconnected", webrtc_connection) await self._call_event_handler("on_client_disconnected", webrtc_connection)
async def _on_client_closed(self, webrtc_connection):
await self._call_event_handler("on_client_closed", webrtc_connection)