From bc11bf96731342a236bb2322190a48aa425395be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=B6kmen=20G=C3=B6rgen?= Date: Tue, 10 Mar 2026 13:48:32 +0100 Subject: [PATCH] remove `_is_filter_enabled` from `AICFilter` and refactor related logic and tests. --- src/pipecat/audio/filters/aic_filter.py | 6 ++---- tests/test_aic_filter.py | 3 --- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/pipecat/audio/filters/aic_filter.py b/src/pipecat/audio/filters/aic_filter.py index fd4e927c2..fc1fe008d 100644 --- a/src/pipecat/audio/filters/aic_filter.py +++ b/src/pipecat/audio/filters/aic_filter.py @@ -259,7 +259,6 @@ class AICFilter(BaseAudioFilter): Path.home() / ".cache" / "pipecat" / "aic-models" ) self._enhancement_level = enhancement_level - self._is_filter_enabled = True self._bypass = False self._sample_rate = 0 @@ -340,7 +339,7 @@ class AICFilter(BaseAudioFilter): if self._enhancement_level is None or self._processor_ctx is None: return - level = float(self._enhancement_level if self._is_filter_enabled else 0.0) + level = float(self._enhancement_level if not self._bypass else 0.0) try: self._processor_ctx.set_parameter(ProcessorParameter.EnhancementLevel, level) @@ -414,7 +413,7 @@ class AICFilter(BaseAudioFilter): logger.debug(f" Sample rate: {self._sample_rate} Hz") logger.debug(f" Frames per chunk: {self._frames_per_block}") if self._enhancement_level is not None: - level = self._enhancement_level if self._is_filter_enabled else 0.0 + level = self._enhancement_level if not self._bypass else 0.0 logger.debug(f" Enhancement strength: {int(level * 100)}%") else: logger.debug(" Enhancement level not configured; using the model's default behavior.") @@ -459,7 +458,6 @@ class AICFilter(BaseAudioFilter): None """ if isinstance(frame, FilterEnableFrame): - self._is_filter_enabled = frame.enable self._bypass = not frame.enable if self._processor_ctx is not None: try: diff --git a/tests/test_aic_filter.py b/tests/test_aic_filter.py index f47b38233..8403f3711 100644 --- a/tests/test_aic_filter.py +++ b/tests/test_aic_filter.py @@ -177,7 +177,6 @@ class TestAICFilter(unittest.IsolatedAsyncioTestCase): self.assertEqual(filter_instance._model_id, "test-model") self.assertIsNone(filter_instance._model_path) self.assertIsNone(filter_instance._enhancement_level) - self.assertTrue(filter_instance._is_filter_enabled) self.assertFalse(filter_instance._bypass) async def test_initialization_with_model_path(self): @@ -540,7 +539,6 @@ class TestAICFilter(unittest.IsolatedAsyncioTestCase): for p, v in self.mock_processor.processor_ctx.parameters_set if p == aic_sdk.ProcessorParameter.Bypass ] - self.assertFalse(filter_instance._is_filter_enabled) self.assertTrue(filter_instance._bypass) self.assertEqual(enhancement_params[-1][1], 0.0) self.assertEqual(bypass_params[-1][1], 1.0) @@ -563,7 +561,6 @@ class TestAICFilter(unittest.IsolatedAsyncioTestCase): for p, v in self.mock_processor.processor_ctx.parameters_set if p == aic_sdk.ProcessorParameter.Bypass ] - self.assertTrue(filter_instance._is_filter_enabled) self.assertFalse(filter_instance._bypass) self.assertEqual(enhancement_params[-1][1], 0.7) self.assertEqual(bypass_params[-1][1], 0.0)