wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Switch ttfb metric to use seconds instead

Browse Source
This commit is contained in:
Philipp Eisen
2025-05-30 11:13:26 +02:00
parent bc97f397ef
commit b712e6b9aa
3 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/pipecat/processors/metrics/frame_processor_metrics.py
View File

@@ -28,18 +28,18 @@ class FrameProcessorMetrics:
self._should_report_ttfb = True self._should_report_ttfb = True
@property @property
def ttfb_ms(self) -> Optional[float]: def ttfb(self) -> Optional[float]:
"""Get the current TTFB value in milliseconds. """Get the current TTFB value in seconds.
Returns: Returns:
Optional[int]: The TTFB value in milliseconds, or None if not measured Optional[float]: The TTFB value in seconds, or None if not measured
""" """
if self._last_ttfb_time > 0: if self._last_ttfb_time > 0:
return self._last_ttfb_time * 1000 return self._last_ttfb_time
# If TTFB is in progress, calculate current value # If TTFB is in progress, calculate current value
if self._start_ttfb_time > 0: if self._start_ttfb_time > 0:
return (time.time() - self._start_ttfb_time) * 1000 return time.time() - self._start_ttfb_time
return None return None

24
src/pipecat/utils/tracing/service_attributes.py
View File

@@ -60,7 +60,7 @@ def add_tts_span_attributes(
settings: Optional[Dict[str, Any]] = None, settings: Optional[Dict[str, Any]] = None,
character_count: Optional[int] = None, character_count: Optional[int] = None,
operation_name: str = "tts", operation_name: str = "tts",
ttfb_ms: Optional[float] = None, ttfb: Optional[float] = None,
**kwargs, **kwargs,
) -> None: ) -> None:
"""Add TTS-specific attributes to a span. """Add TTS-specific attributes to a span.
@@ -74,7 +74,7 @@ def add_tts_span_attributes(
settings: Service configuration settings settings: Service configuration settings
character_count: Number of characters in the text character_count: Number of characters in the text
operation_name: Name of the operation (default: "tts") operation_name: Name of the operation (default: "tts")
ttfb_ms: Time to first byte in milliseconds ttfb: Time to first byte in seconds
**kwargs: Additional attributes to add **kwargs: Additional attributes to add
""" """
# Add standard attributes # Add standard attributes
@@ -91,8 +91,8 @@ def add_tts_span_attributes(
if character_count is not None: if character_count is not None:
span.set_attribute("metrics.character_count", character_count) span.set_attribute("metrics.character_count", character_count)
if ttfb_ms is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb_ms", ttfb_ms) span.set_attribute("metrics.ttfb", ttfb)
# Add settings if provided # Add settings if provided
if settings: if settings:
@@ -116,7 +116,7 @@ def add_stt_span_attributes(
language: Optional[str] = None, language: Optional[str] = None,
settings: Optional[Dict[str, Any]] = None, settings: Optional[Dict[str, Any]] = None,
vad_enabled: bool = False, vad_enabled: bool = False,
ttfb_ms: Optional[float] = None, ttfb: Optional[float] = None,
**kwargs, **kwargs,
) -> None: ) -> None:
"""Add STT-specific attributes to a span. """Add STT-specific attributes to a span.
@@ -131,7 +131,7 @@ def add_stt_span_attributes(
language: Detected or configured language language: Detected or configured language
settings: Service configuration settings settings: Service configuration settings
vad_enabled: Whether voice activity detection is enabled vad_enabled: Whether voice activity detection is enabled
ttfb_ms: Time to first byte in milliseconds ttfb: Time to first byte in seconds
**kwargs: Additional attributes to add **kwargs: Additional attributes to add
""" """
# Add standard attributes # Add standard attributes
@@ -150,8 +150,8 @@ def add_stt_span_attributes(
if language: if language:
span.set_attribute("language", language) span.set_attribute("language", language)
if ttfb_ms is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb_ms", ttfb_ms) span.set_attribute("metrics.ttfb", ttfb)
# Add settings if provided # Add settings if provided
if settings: if settings:
@@ -178,7 +178,7 @@ def add_llm_span_attributes(
system: Optional[str] = None, system: Optional[str] = None,
parameters: Optional[Dict[str, Any]] = None, parameters: Optional[Dict[str, Any]] = None,
extra_parameters: Optional[Dict[str, Any]] = None, extra_parameters: Optional[Dict[str, Any]] = None,
ttfb_ms: Optional[float] = None, ttfb: Optional[float] = None,
**kwargs, **kwargs,
) -> None: ) -> None:
"""Add LLM-specific attributes to a span. """Add LLM-specific attributes to a span.
@@ -196,7 +196,7 @@ def add_llm_span_attributes(
system: System message system: System message
parameters: Service parameters parameters: Service parameters
extra_parameters: Additional parameters extra_parameters: Additional parameters
ttfb_ms: Time to first byte in milliseconds ttfb: Time to first byte in seconds
**kwargs: Additional attributes to add **kwargs: Additional attributes to add
""" """
# Add standard attributes # Add standard attributes
@@ -225,8 +225,8 @@ def add_llm_span_attributes(
if system: if system:
span.set_attribute("system", system) span.set_attribute("system", system)
if ttfb_ms is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb_ms", ttfb_ms) span.set_attribute("metrics.ttfb", ttfb)
# Add parameters if provided # Add parameters if provided
if parameters: if parameters:

16
src/pipecat/utils/tracing/service_decorators.py
View File

@@ -152,9 +152,9 @@ def traced_tts(func: Optional[Callable] = None, *, name: Optional[str] = None) -
raise raise
finally: finally:
# Update TTFB metric at the end # Update TTFB metric at the end
ttfb_ms: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb_ms", None) ttfb: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb", None)
if ttfb_ms is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb_ms", ttfb_ms) span.set_attribute("metrics.ttfb", ttfb)
if is_async_generator: if is_async_generator:
@@ -238,7 +238,7 @@ def traced_stt(func: Optional[Callable] = None, *, name: Optional[str] = None) -
) as current_span: ) as current_span:
try: try:
# Get TTFB metric if available # Get TTFB metric if available
ttfb_ms: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb_ms", None) ttfb: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb", None)
# Use settings from the service if available # Use settings from the service if available
settings = getattr(self, "_settings", {}) settings = getattr(self, "_settings", {})
@@ -252,7 +252,7 @@ def traced_stt(func: Optional[Callable] = None, *, name: Optional[str] = None) -
language=str(language) if language else None, language=str(language) if language else None,
vad_enabled=getattr(self, "vad_enabled", False), vad_enabled=getattr(self, "vad_enabled", False),
settings=settings, settings=settings,
ttfb_ms=ttfb_ms, ttfb=ttfb,
) )
# Call the original function # Call the original function
@@ -460,9 +460,9 @@ def traced_llm(func: Optional[Callable] = None, *, name: Optional[str] = None) -
self.start_llm_usage_metrics = original_start_llm_usage_metrics self.start_llm_usage_metrics = original_start_llm_usage_metrics
# Update TTFB metric # Update TTFB metric
ttfb_ms: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb_ms", None) ttfb: Optional[float] = getattr(getattr(self, "_metrics", None), "ttfb", None)
if ttfb_ms is not None: if ttfb is not None:
current_span.set_attribute("metrics.ttfb_ms", ttfb_ms) current_span.set_attribute("metrics.ttfb", ttfb)
except Exception as e: except Exception as e:
logging.error(f"Error in LLM tracing (continuing without tracing): {e}") logging.error(f"Error in LLM tracing (continuing without tracing): {e}")
# If tracing fails, fall back to the original function # If tracing fails, fall back to the original function