wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replace background task with flush-on-join

Browse Source
This commit is contained in:
Om Chauhan
2026-02-09 06:04:08 +05:30
parent 9f380170d7
commit a4e187e138
1 changed files with 8 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/pipecat/transports/daily/transport.py
View File

@@ -501,8 +501,7 @@ class DailyTransportClient(EventHandler):
self._event_task = None self._event_task = None
self._audio_task = None self._audio_task = None
self._video_task = None self._video_task = None
self._message_queue: Optional[asyncio.Queue] = None self._join_message_queue: list = []
self._message_task = None
# Input and ouput sample rates. They will be initialize on setup(). # Input and ouput sample rates. They will be initialize on setup().
self._in_sample_rate = 0 self._in_sample_rate = 0
@@ -569,8 +568,7 @@ class DailyTransportClient(EventHandler):
error: An error description or None. error: An error description or None.
""" """
if not self._joined: if not self._joined:
if self._message_queue: self._join_message_queue.append(frame)
await self._message_queue.put((frame,))
return None return None
participant_id = None participant_id = None
@@ -677,12 +675,6 @@ class DailyTransportClient(EventHandler):
f"{self}::event_callback_task", f"{self}::event_callback_task",
) )
self._message_queue = asyncio.Queue()
self._message_task = self._task_manager.create_task(
self._message_task_handler(self._message_queue),
f"{self}::message_task",
)
async def cleanup(self): async def cleanup(self):
"""Cleanup client resources and cancel tasks.""" """Cleanup client resources and cancel tasks."""
if self._event_task and self._task_manager: if self._event_task and self._task_manager:
@@ -694,9 +686,6 @@ class DailyTransportClient(EventHandler):
if self._video_task and self._task_manager: if self._video_task and self._task_manager:
await self._task_manager.cancel_task(self._video_task) await self._task_manager.cancel_task(self._video_task)
self._video_task = None self._video_task = None
if self._message_task and self._task_manager:
await self._task_manager.cancel_task(self._message_task)
self._message_task = None
# Make sure we don't block the event loop in case `client.release()` # Make sure we don't block the event loop in case `client.release()`
# takes extra time. # takes extra time.
await self._get_event_loop().run_in_executor(self._executor, self._cleanup) await self._get_event_loop().run_in_executor(self._executor, self._cleanup)
@@ -781,6 +770,8 @@ class DailyTransportClient(EventHandler):
await self._callbacks.on_joined(data) await self._callbacks.on_joined(data)
self._joined_event.set() self._joined_event.set()
await self._flush_join_messages()
else: else:
error_msg = f"Error joining {self._room_url}: {error}" error_msg = f"Error joining {self._room_url}: {error}"
logger.error(error_msg) logger.error(error_msg)
@@ -1554,13 +1545,11 @@ class DailyTransportClient(EventHandler):
await callback(*args) await callback(*args)
queue.task_done() queue.task_done()
async def _message_task_handler(self, queue: asyncio.Queue): async def _flush_join_messages(self):
"""Handle queued messages after transport is joined.""" """Send any messages that were queued before join completed."""
while True: for frame in self._join_message_queue:
await self._joined_event.wait()
(frame,) = await queue.get()
await self.send_message(frame) await self.send_message(frame)
queue.task_done() self._join_message_queue.clear()
def _get_event_loop(self) -> asyncio.AbstractEventLoop: def _get_event_loop(self) -> asyncio.AbstractEventLoop:
"""Get the event loop from the task manager.""" """Get the event loop from the task manager."""