From 9ddec0f8b491cdbe4513a494449eaaa9734dde57 Mon Sep 17 00:00:00 2001 From: nbyers-altira Date: Mon, 13 Oct 2025 10:44:25 -0400 Subject: [PATCH 1/4] is_final is not part of the segmented _handle_transcription function signature --- src/pipecat/services/riva/stt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pipecat/services/riva/stt.py b/src/pipecat/services/riva/stt.py index d00eb4f42..f077355f4 100644 --- a/src/pipecat/services/riva/stt.py +++ b/src/pipecat/services/riva/stt.py @@ -647,7 +647,7 @@ class RivaSegmentedSTTService(SegmentedSTTService): ) transcription_found = True - await self._handle_transcription(text, True, self._language_enum) + await self._handle_transcription(text, self._language_enum) if not transcription_found: logger.debug("No transcription results found in Riva response") From cc66ac14f1699357bc2e39be9adac376721bbcac Mon Sep 17 00:00:00 2001 From: nbyers-altira Date: Mon, 13 Oct 2025 10:48:41 -0400 Subject: [PATCH 2/4] add is_final to segmented func. sig. instead so tracing is consistent --- src/pipecat/services/riva/stt.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pipecat/services/riva/stt.py b/src/pipecat/services/riva/stt.py index f077355f4..ccd166536 100644 --- a/src/pipecat/services/riva/stt.py +++ b/src/pipecat/services/riva/stt.py @@ -583,7 +583,7 @@ class RivaSegmentedSTTService(SegmentedSTTService): self._config.language_code = self._language @traced_stt - async def _handle_transcription(self, transcript: str, language: Optional[Language] = None): + async def _handle_transcription(self, transcript: str, is_final: bool, language: Optional[Language] = None): """Handle a transcription result with tracing.""" pass @@ -647,7 +647,7 @@ class RivaSegmentedSTTService(SegmentedSTTService): ) transcription_found = True - await self._handle_transcription(text, self._language_enum) + await self._handle_transcription(text, True, self._language_enum) if not transcription_found: logger.debug("No transcription results found in Riva response") From a67a765783dccbf4893d535722d8d15f6c7894e9 Mon Sep 17 00:00:00 2001 From: nbyers-altira Date: Fri, 17 Oct 2025 13:49:52 -0400 Subject: [PATCH 3/4] add changelog, run linter --- CHANGELOG.md | 3 +++ src/pipecat/services/riva/stt.py | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d581ccce..96406e52f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fixed an issue in `RivaSTTService` where a runtime error occurred due to a + mismatch in the _handle_transcription method's signature. + - Fixed multiple pipeline task cancellation issues. `asyncio.CancelledError` is now handled properly in `PipelineTask` making it possible to cancel an asyncio task that it's executing a `PipelineRunner` cleanly. Also, diff --git a/src/pipecat/services/riva/stt.py b/src/pipecat/services/riva/stt.py index ccd166536..eddd3da9e 100644 --- a/src/pipecat/services/riva/stt.py +++ b/src/pipecat/services/riva/stt.py @@ -583,7 +583,9 @@ class RivaSegmentedSTTService(SegmentedSTTService): self._config.language_code = self._language @traced_stt - async def _handle_transcription(self, transcript: str, is_final: bool, language: Optional[Language] = None): + async def _handle_transcription( + self, transcript: str, is_final: bool, language: Optional[Language] = None + ): """Handle a transcription result with tracing.""" pass From a4867f61aa51497c78e2043e55f037519051c9f7 Mon Sep 17 00:00:00 2001 From: nbyers-altira Date: Fri, 17 Oct 2025 13:51:49 -0400 Subject: [PATCH 4/4] be a tad more precise in changelog --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96406e52f..5d8d44887 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,8 +38,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Fixed an issue in `RivaSTTService` where a runtime error occurred due to a - mismatch in the _handle_transcription method's signature. +- Fixed an issue in `RivaSegmentedSTTService` where a runtime error occurred due + to a mismatch in the _handle_transcription method's signature. - Fixed multiple pipeline task cancellation issues. `asyncio.CancelledError` is now handled properly in `PipelineTask` making it possible to cancel an asyncio