wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enable_dialout should not depend on sip_caller_phone being set (#4087)

Browse Source 
* enable_dialout should not depend on SIP being set

* we still need room_prefix to have pipecat-sip, s/sip/telephony in room prefix
This commit is contained in:
Varun Singh
2026-03-20 10:01:31 -07:00
committed by GitHub
parent 44504efdc7
commit a12ad27348
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pipecat/runner/daily.py
View File

@@ -207,7 +207,7 @@ async def configure(
return DailyRoomConfig(room_url=room_url, token=token) return DailyRoomConfig(room_url=room_url, token=token)
# Create a new room # Create a new room
room_prefix = "pipecat-sip" if sip_enabled else "pipecat" room_prefix = "pipecat-telephony" if (sip_enabled or enable_dialout) else "pipecat"
room_name = f"{room_prefix}-{uuid.uuid4().hex[:8]}" room_name = f"{room_prefix}-{uuid.uuid4().hex[:8]}"
logger.info(f"Creating new Daily room: {room_name}") logger.info(f"Creating new Daily room: {room_name}")
@@ -225,6 +225,9 @@ async def configure(
if room_geo: if room_geo:
room_properties.geo = room_geo room_properties.geo = room_geo
if enable_dialout:
room_properties.enable_dialout = True
# Add SIP configuration if enabled # Add SIP configuration if enabled
if sip_enabled: if sip_enabled:
sip_params = DailyRoomSipParams( sip_params = DailyRoomSipParams(
@@ -236,7 +239,6 @@ async def configure(
provider=sip_provider, provider=sip_provider,
) )
room_properties.sip = sip_params room_properties.sip = sip_params
room_properties.enable_dialout = enable_dialout
room_properties.start_video_off = not sip_enable_video # Voice-only by default room_properties.start_video_off = not sip_enable_video # Voice-only by default
# Create room parameters # Create room parameters