wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1144 from pipecat-ai/aleix/frame-processor-missing-init-warning

Browse Source 
FrameProcessor: add an error about missing super().process_frame(...)
This commit is contained in:
Aleix Conchillo Flaqué
2025-02-06 07:18:35 -08:00
committed by GitHub
parent 99d3227ff5 bc21a0b817
commit 975b97472a
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/pipecat/processors/frame_processor.py
View File

@@ -245,6 +245,9 @@ class FrameProcessor:
await self.push_frame(error, FrameDirection.UPSTREAM) await self.push_frame(error, FrameDirection.UPSTREAM)
async def push_frame(self, frame: Frame, direction: FrameDirection = FrameDirection.DOWNSTREAM): async def push_frame(self, frame: Frame, direction: FrameDirection = FrameDirection.DOWNSTREAM):
if not self._check_ready(frame):
return
if isinstance(frame, SystemFrame): if isinstance(frame, SystemFrame):
await self.__internal_push_frame(frame, direction) await self.__internal_push_frame(frame, direction)
else: else:
@@ -319,6 +322,16 @@ class FrameProcessor:
await self.push_error(ErrorFrame(str(e))) await self.push_error(ErrorFrame(str(e)))
raise raise
def _check_ready(self, frame: Frame):
# If we are trying to push a frame but we still have no clock, it means
# we didn't process a StartFrame.
if not self._clock:
logger.error(
f"{self} not properly initialized, missing super().process_frame(frame, direction)?"
)
return False
return True
def __create_input_task(self): def __create_input_task(self):
if not self.__input_frame_task: if not self.__input_frame_task:
self.__should_block_frames = False self.__should_block_frames = False