Code review feedback

CHANGELOG.md

@@ -25,10 +25,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Messages emitted with ISO 8601 timestamps indicating when they were spoken.
   - Supports all LLM formats (OpenAI, Anthropic, Google) via standard message
     format.
-  - Shared event handling for both user and assistant transcript updates.
   - New examples: `28a-transcription-processor-openai.py`,
     `28b-transcription-processor-anthropic.py`, and
-    `28c-transcription-processor-gemini.py`
+    `28c-transcription-processor-gemini.py`.
 
 - Add support for more languages to ElevenLabs (Arabic, Croatian, Filipino,
   Tamil) and PlayHT (Afrikans, Albanian, Amharic, Arabic, Bengali, Croatian,

src/pipecat/processors/transcript_processor.py

@@ -4,13 +4,9 @@
 # SPDX-License-Identifier: BSD 2-Clause License
 #
 
-from abc import ABC, abstractmethod
 from typing import List
 
-from loguru import logger
-
 from pipecat.frames.frames import (
-    ErrorFrame,
     Frame,
     OpenAILLMContextAssistantTimestampFrame,
     TranscriptionFrame,
@@ -21,7 +17,7 @@ from pipecat.processors.aggregators.openai_llm_context import OpenAILLMContextFr
 from pipecat.processors.frame_processor import FrameDirection, FrameProcessor
 
 
-class BaseTranscriptProcessor(FrameProcessor, ABC):
+class BaseTranscriptProcessor(FrameProcessor):
     """Base class for processing conversation transcripts.
 
     Provides common functionality for handling transcript messages and updates.
@@ -45,16 +41,6 @@ class BaseTranscriptProcessor(FrameProcessor, ABC):
             await self._call_event_handler("on_transcript_update", update_frame)
             await self.push_frame(update_frame)
 
-    @abstractmethod
-    async def process_frame(self, frame: Frame, direction: FrameDirection):
-        """Process incoming frames to build conversation transcript.
-
-        Args:
-            frame: Input frame to process
-            direction: Frame processing direction
-        """
-        await super().process_frame(frame, direction)
-
 
 class UserTranscriptProcessor(BaseTranscriptProcessor):
     """Processes user transcription frames into timestamped conversation messages."""
@@ -195,18 +181,44 @@ class TranscriptProcessor:
         ```
     """
 
-    def __init__(self, **kwargs):
+    def __init__(self):
-        """Initialize factory with user and assistant processors."""
+        """Initialize factory."""
-        self._user_processor = UserTranscriptProcessor(**kwargs)
+        self._user_processor = None
-        self._assistant_processor = AssistantTranscriptProcessor(**kwargs)
+        self._assistant_processor = None
         self._event_handlers = {}
 
-    def user(self) -> UserTranscriptProcessor:
+    def user(self, **kwargs) -> UserTranscriptProcessor:
-        """Get the user transcript processor."""
+        """Get the user transcript processor.
+
+        Args:
+            **kwargs: Arguments specific to UserTranscriptProcessor
+        """
+        if self._user_processor is None:
+            self._user_processor = UserTranscriptProcessor(**kwargs)
+            # Apply any registered event handlers
+            for event_name, handler in self._event_handlers.items():
+
+                @self._user_processor.event_handler(event_name)
+                async def user_handler(processor, frame):
+                    return await handler(processor, frame)
+
         return self._user_processor
 
-    def assistant(self) -> AssistantTranscriptProcessor:
+    def assistant(self, **kwargs) -> AssistantTranscriptProcessor:
-        """Get the assistant transcript processor."""
+        """Get the assistant transcript processor.
+
+        Args:
+            **kwargs: Arguments specific to AssistantTranscriptProcessor
+        """
+        if self._assistant_processor is None:
+            self._assistant_processor = AssistantTranscriptProcessor(**kwargs)
+            # Apply any registered event handlers
+            for event_name, handler in self._event_handlers.items():
+
+                @self._assistant_processor.event_handler(event_name)
+                async def assistant_handler(processor, frame):
+                    return await handler(processor, frame)
+
         return self._assistant_processor
 
     def event_handler(self, event_name: str):
@@ -222,13 +234,18 @@ class TranscriptProcessor:
         def decorator(handler):
             self._event_handlers[event_name] = handler
 
-            @self._user_processor.event_handler(event_name)
+            # Apply handler to existing processors if they exist
-            async def user_handler(processor, frame):
+            if self._user_processor:
-                return await handler(processor, frame)
 
-            @self._assistant_processor.event_handler(event_name)
+                @self._user_processor.event_handler(event_name)
-            async def assistant_handler(processor, frame):
+                async def user_handler(processor, frame):
-                return await handler(processor, frame)
+                    return await handler(processor, frame)
+
+            if self._assistant_processor:
+
+                @self._assistant_processor.event_handler(event_name)
+                async def assistant_handler(processor, frame):
+                    return await handler(processor, frame)
 
             return handler