wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #433 from pipecat-ai/aleix/process-all-startframes

Browse Source 
StartFrame should be the first frame every processor receives
This commit is contained in:
Aleix Conchillo Flaqué
2024-08-30 14:17:38 -07:00
committed by GitHub
parent 05f0492a8d 37e2388758
commit 7c342f7ba2
4 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pipecat/processors/frameworks/rtvi.py
View File

@@ -356,8 +356,10 @@ class RTVIProcessor(FrameProcessor):
await self.push_frame(frame, direction) await self.push_frame(frame, direction)
# Control frames # Control frames
elif isinstance(frame, StartFrame): elif isinstance(frame, StartFrame):
await self._start(frame) # Push StartFrame before start(), because we want StartFrame to be
# processed by every processor before any other frame is processed.
await self.push_frame(frame, direction) await self.push_frame(frame, direction)
await self._start(frame)
elif isinstance(frame, EndFrame): elif isinstance(frame, EndFrame):
# Push EndFrame before stop(), because stop() waits on the task to # Push EndFrame before stop(), because stop() waits on the task to
# finish and the task finishes when EndFrame is processed. # finish and the task finishes when EndFrame is processed.

4
src/pipecat/processors/gstreamer/pipeline_source.py
View File

@@ -78,8 +78,10 @@ class GStreamerPipelineSource(FrameProcessor):
await self.push_frame(frame, direction) await self.push_frame(frame, direction)
# Control frames # Control frames
elif isinstance(frame, StartFrame): elif isinstance(frame, StartFrame):
await self._start(frame) # Push StartFrame before start(), because we want StartFrame to be
# processed by every processor before any other frame is processed.
await self._internal_push_frame(frame, direction) await self._internal_push_frame(frame, direction)
await self._start(frame)
elif isinstance(frame, EndFrame): elif isinstance(frame, EndFrame):
# Push EndFrame before stop(), because stop() waits on the task to # Push EndFrame before stop(), because stop() waits on the task to
# finish and the task finishes when EndFrame is processed. # finish and the task finishes when EndFrame is processed.

4
src/pipecat/transports/base_input.py
View File

@@ -96,8 +96,10 @@ class BaseInputTransport(FrameProcessor):
await self.push_frame(frame, direction) await self.push_frame(frame, direction)
# Control frames # Control frames
elif isinstance(frame, StartFrame): elif isinstance(frame, StartFrame):
await self.start(frame) # Push StartFrame before start(), because we want StartFrame to be
# processed by every processor before any other frame is processed.
await self._internal_push_frame(frame, direction) await self._internal_push_frame(frame, direction)
await self.start(frame)
elif isinstance(frame, EndFrame): elif isinstance(frame, EndFrame):
# Push EndFrame before stop(), because stop() waits on the task to # Push EndFrame before stop(), because stop() waits on the task to
# finish and the task finishes when EndFrame is processed. # finish and the task finishes when EndFrame is processed.

2
src/pipecat/transports/base_output.py
View File

@@ -134,8 +134,8 @@ class BaseOutputTransport(FrameProcessor):
# queue. # queue.
# #
if isinstance(frame, CancelFrame): if isinstance(frame, CancelFrame):
await self.push_frame(frame, direction)
await self.cancel(frame) await self.cancel(frame)
await self.push_frame(frame, direction)
elif isinstance(frame, StartInterruptionFrame) or isinstance(frame, StopInterruptionFrame): elif isinstance(frame, StartInterruptionFrame) or isinstance(frame, StopInterruptionFrame):
await self.push_frame(frame, direction) await self.push_frame(frame, direction)
await self._handle_interruptions(frame) await self._handle_interruptions(frame)