Merge pull request #3938 from koriyoshi2041/fix/replace-bare-except-handlers

fix: replace bare except handlers with specific exception types

examples/foundational/39-mcp-stdio.py

@@ -70,7 +70,7 @@ class UrlToImageProcessor(FrameProcessor):
                 return data["artObject"]["webImage"]["url"]
             if "artworks" in data and len(data["artworks"]):
                 return data["artworks"][0]["webImage"]["url"]
-        except:
+        except (json.JSONDecodeError, KeyError, TypeError):
             pass
 
         return None

examples/foundational/39c-multiple-mcp.py

@@ -72,7 +72,7 @@ class UrlToImageProcessor(FrameProcessor):
                 return data["artObject"]["webImage"]["url"]
             if "artworks" in data and len(data["artworks"]):
                 return data["artworks"][0]["webImage"]["url"]
-        except:
+        except (json.JSONDecodeError, KeyError, TypeError):
             pass
 
     async def run_image_process(self, image_url: str):

src/pipecat/adapters/services/bedrock_adapter.py

@@ -209,7 +209,7 @@ class AWSBedrockLLMAdapter(BaseLLMAdapter[AWSBedrockLLMInvocationParams]):
                     tool_result_content = [{"json": content_json}]
                 else:
                     tool_result_content = [{"text": message["content"]}]
-            except:
+            except (json.JSONDecodeError, ValueError, AttributeError):
                 tool_result_content = [{"text": message["content"]}]
 
             return {

src/pipecat/serializers/telnyx.py

@@ -198,7 +198,7 @@ class TelnyxFrameSerializer(FrameSerializer):
                                     f"Telnyx call {call_control_id} was already terminated"
                                 )
                                 return
-                        except:
+                        except Exception:
                             pass  # Fall through to log the raw error
 
                         # Log other 422 errors

src/pipecat/serializers/twilio.py

@@ -212,7 +212,7 @@ class TwilioFrameSerializer(FrameSerializer):
                             if error_data.get("code") == 20404:
                                 logger.debug(f"Twilio call {call_sid} was already terminated")
                                 return
-                        except:
+                        except Exception:
                             pass  # Fall through to log the raw error
 
                         # Log other 404 errors

src/pipecat/services/aws/llm.py

@@ -371,7 +371,7 @@ class AWSBedrockLLMContext(OpenAILLMContext):
                     tool_result_content = [{"json": content_json}]
                 else:
                     tool_result_content = [{"text": message["content"]}]
-            except:
+            except (json.JSONDecodeError, ValueError, AttributeError):
                 tool_result_content = [{"text": message["content"]}]
 
             return {

src/pipecat/services/mcp_service.py

@@ -296,10 +296,7 @@ class MCPClient(BaseObject):
         available_tools = await session.list_tools()
         tool_schemas: List[FunctionSchema] = []
 
-        try:
+        logger.debug(f"Found {len(available_tools.tools)} available tools")
-            logger.debug(f"Found {len(available_tools)} available tools")
-        except:
-            pass
 
         for tool in available_tools.tools:
             tool_name = tool.name