Merge pull request #812 from zzz-heygen/zzz/fix_serializer_backward_compat
fix: make ProtobufFrameSerializer backwards compatible
This commit is contained in:
@@ -90,14 +90,14 @@ class ProtobufFrameSerializer(FrameSerializer):
|
|||||||
args_dict[field.name] = getattr(args, field.name)
|
args_dict[field.name] = getattr(args, field.name)
|
||||||
|
|
||||||
# Remove special fields if needed
|
# Remove special fields if needed
|
||||||
id = getattr(args, "id")
|
id = getattr(args, "id", None)
|
||||||
name = getattr(args, "name")
|
name = getattr(args, "name", None)
|
||||||
pts = getattr(args, "pts")
|
pts = getattr(args, "pts", None)
|
||||||
if not id:
|
if not id and "id" in args_dict:
|
||||||
del args_dict["id"]
|
del args_dict["id"]
|
||||||
if not name:
|
if not name and "name" in args_dict:
|
||||||
del args_dict["name"]
|
del args_dict["name"]
|
||||||
if not pts:
|
if not pts and "pts" in args_dict:
|
||||||
del args_dict["pts"]
|
del args_dict["pts"]
|
||||||
|
|
||||||
# Create the instance
|
# Create the instance
|
||||||
@@ -105,10 +105,10 @@ class ProtobufFrameSerializer(FrameSerializer):
|
|||||||
|
|
||||||
# Set special fields
|
# Set special fields
|
||||||
if id:
|
if id:
|
||||||
setattr(instance, "id", getattr(args, "id"))
|
setattr(instance, "id", getattr(args, "id", None))
|
||||||
if name:
|
if name:
|
||||||
setattr(instance, "name", getattr(args, "name"))
|
setattr(instance, "name", getattr(args, "name", None))
|
||||||
if pts:
|
if pts:
|
||||||
setattr(instance, "pts", getattr(args, "pts"))
|
setattr(instance, "pts", getattr(args, "pts", None))
|
||||||
|
|
||||||
return instance
|
return instance
|
||||||
|
|||||||
Reference in New Issue
Block a user