From 5e338ecaf1301a84d578e01bee05f03ad9248741 Mon Sep 17 00:00:00 2001 From: Designedforusers Date: Sat, 2 Aug 2025 15:02:54 -0400 Subject: [PATCH] refactor: Remove redundant transcription callback methods As suggested in PR review, removed the _on_transcription_stopped and _on_transcription_error method definitions. Now using the consistent partial(self._on_handle_callback, ...) pattern for these callbacks, matching how all other callbacks are handled. This simplifies the code while maintaining the same functionality. --- src/pipecat/transports/services/tavus.py | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/src/pipecat/transports/services/tavus.py b/src/pipecat/transports/services/tavus.py index 4d4eec7f0..119ce2b8c 100644 --- a/src/pipecat/transports/services/tavus.py +++ b/src/pipecat/transports/services/tavus.py @@ -245,8 +245,8 @@ class TavusTransportClient: on_recording_started=partial(self._on_handle_callback, "on_recording_started"), on_recording_stopped=partial(self._on_handle_callback, "on_recording_stopped"), on_recording_error=partial(self._on_handle_callback, "on_recording_error"), - on_transcription_stopped=self._on_transcription_stopped, - on_transcription_error=self._on_transcription_error, + on_transcription_stopped=partial(self._on_handle_callback, "on_transcription_stopped"), + on_transcription_error=partial(self._on_handle_callback, "on_transcription_error"), ) self._client = DailyTransportClient( room_url, None, "Pipecat", self._params, daily_callbacks, self._bot_name @@ -276,20 +276,6 @@ class TavusTransportClient: """Handle generic callback events.""" logger.trace(f"[Callback] {event_name} called with args={args}, kwargs={kwargs}") - async def _on_transcription_stopped(self, stopped_by: str, stopped_by_error: bool): - """ - Placeholder for transcription stopped callback. - Required by DailyCallbacks in Pipecat 0.0.77+ but not used by Tavus. - """ - pass - - async def _on_transcription_error(self, message: str): - """ - Placeholder for transcription error callback. - Required by DailyCallbacks in Pipecat 0.0.77+ but not used by Tavus. - """ - pass - async def get_persona_name(self) -> str: """Get the persona name from the API.