wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2729 from pipecat-ai/aleix/frame-processor-cancel-default-timeout

Browse Source 
FrameProcessor: timeout when cancelling tasks
This commit is contained in:
Aleix Conchillo Flaqué
2025-09-24 10:55:52 -07:00
committed by GitHub
parent 0f87d5342c f9eb447d82
commit 508f7d203d
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@@ -113,6 +113,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed an issue where the pipeline could freeze if a task cancellation never
completed because a third-party library swallowed asyncio.CancelledError. We
now apply a timeout to task cancellations to prevent these freezes. If the
timeout is reached, the system logs warnings and leaves dangling tasks behind,
which can help diagnose where cancellation is being blocked.
- Fixed an `AudioBufferProcessor` issues that was causing user audio to be - Fixed an `AudioBufferProcessor` issues that was causing user audio to be
missing in stereo recordings causing bot and user overlaps. missing in stereo recordings causing bot and user overlaps.

6
src/pipecat/processors/frame_processor.py
View File

@@ -455,9 +455,13 @@ class FrameProcessor(BaseObject):
name = f"{self}::{coroutine.cr_code.co_name}" name = f"{self}::{coroutine.cr_code.co_name}"
return self.task_manager.create_task(coroutine, name) return self.task_manager.create_task(coroutine, name)
async def cancel_task(self, task: asyncio.Task, timeout: Optional[float] = None): async def cancel_task(self, task: asyncio.Task, timeout: Optional[float] = 1.0):
"""Cancel a task managed by this processor. """Cancel a task managed by this processor.
A default timeout if 1 second is used in order to avoid potential
freezes caused by certain libraries that swallow
`asyncio.CancelledError`.
Args: Args:
task: The task to cancel. task: The task to cancel.
timeout: Optional timeout for task cancellation. timeout: Optional timeout for task cancellation.