Merge pull request #2411 from pipecat-ai/mb/fix-websocket-service-retry

fix: WebsocketService retry logic incorrectly handling ConnectionClos…
This commit is contained in:
Mark Backman
2025-08-11 18:17:50 -07:00
committed by GitHub
2 changed files with 11 additions and 7 deletions

View File

@@ -12,6 +12,7 @@ from typing import Awaitable, Callable, Optional
import websockets
from loguru import logger
from websockets.exceptions import ConnectionClosedOK
from websockets.protocol import State
from pipecat.frames.frames import ErrorFrame
@@ -82,12 +83,10 @@ class WebsocketService(ABC):
try:
await self._receive_messages()
retry_count = 0 # Reset counter on successful message receive
if self._websocket and self._websocket.state is State.CLOSED:
raise websockets.ConnectionClosedOK(
self._websocket.close_rcvd,
self._websocket.close_sent,
self._websocket.close_rcvd_then_sent,
)
except ConnectionClosedOK as e:
# Normal closure, don't retry
logger.debug(f"{self} connection closed normally: {e}")
break
except Exception as e:
message = f"{self} error receiving messages: {e}"
logger.error(message)