wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3899 from pipecat-ai/mb/tracing-service-settings-comment

Browse Source 
Add defensive comment for given_fields() usage in tracing
This commit is contained in:
Mark Backman
2026-03-10 15:33:57 -04:00
committed by GitHub
parent 743e2ac277 68d7e98f95
commit 43a9e9a1b5
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pipecat/utils/tracing/service_attributes.py
View File

@@ -107,7 +107,7 @@ def add_tts_span_attributes(
if ttfb is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb", ttfb) span.set_attribute("metrics.ttfb", ttfb)
# Add settings if provided # Use given_fields() defensively in case a service doesn't initialize all settings.
if settings: if settings:
for key, value in settings.given_fields().items(): for key, value in settings.given_fields().items():
if isinstance(value, (str, int, float, bool)): if isinstance(value, (str, int, float, bool)):
@@ -171,7 +171,7 @@ def add_stt_span_attributes(
if ttfb is not None: if ttfb is not None:
span.set_attribute("metrics.ttfb", ttfb) span.set_attribute("metrics.ttfb", ttfb)
# Add settings if provided # Use given_fields() defensively in case a service doesn't initialize all settings.
if settings: if settings:
for key, value in settings.given_fields().items(): for key, value in settings.given_fields().items():
if isinstance(value, (str, int, float, bool)): if isinstance(value, (str, int, float, bool)):
@@ -359,7 +359,7 @@ def add_gemini_live_span_attributes(
if tools_serialized: if tools_serialized:
span.set_attribute("tools.definitions", tools_serialized) span.set_attribute("tools.definitions", tools_serialized)
# Add settings if provided # Use given_fields() defensively in case a service doesn't initialize all settings.
if settings: if settings:
for key, value in settings.given_fields().items(): for key, value in settings.given_fields().items():
if isinstance(value, (str, int, float, bool)): if isinstance(value, (str, int, float, bool)):

3
src/pipecat/utils/tracing/service_decorators.py
View File

@@ -507,7 +507,8 @@ def traced_llm(func: Optional[Callable] = None, *, name: Optional[str] = None) -
elif hasattr(self, "_system_instruction"): elif hasattr(self, "_system_instruction"):
system_message = self._system_instruction system_message = self._system_instruction
# Get settings from the service # Use given_fields() defensively in case a service doesn't
# initialize all settings.
params = {} params = {}
if hasattr(self, "_settings"): if hasattr(self, "_settings"):
for key, value in self._settings.given_fields().items(): for key, value in self._settings.given_fields().items():