wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

transports(websocket): fix _audio_buffer being accidentally overwritten

Browse Source 
`BaseOutputTransport` declares an `_audio_buffer` instance variable.
`WebsocketServerOutputTransport` accidentally reuses that variable
internally assuming it's class-local and not inherited.

This PR renames the variable in `WebsocketServerOutputTransport`
to avoid the name collision.
This commit is contained in:
Sharvil Nanavati
2024-08-17 05:28:05 +00:00
parent d2dfa93bf1
commit 374f1e7e01
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/pipecat/transports/network/websocket_server.py
View File

@@ -120,7 +120,7 @@ class WebsocketServerOutputTransport(BaseOutputTransport):
self._websocket: websockets.WebSocketServerProtocol | None = None self._websocket: websockets.WebSocketServerProtocol | None = None
self._audio_buffer = bytes() self._websocket_audio_buffer = bytes()
async def set_client_connection(self, websocket: websockets.WebSocketServerProtocol | None): async def set_client_connection(self, websocket: websockets.WebSocketServerProtocol | None):
if self._websocket: if self._websocket:
@@ -132,10 +132,10 @@ class WebsocketServerOutputTransport(BaseOutputTransport):
if not self._websocket: if not self._websocket:
return return
self._audio_buffer += frames self._websocket_audio_buffer += frames
while len(self._audio_buffer) >= self._params.audio_frame_size: while len(self._websocket_audio_buffer) >= self._params.audio_frame_size:
frame = AudioRawFrame( frame = AudioRawFrame(
audio=self._audio_buffer[:self._params.audio_frame_size], audio=self._websocket_audio_buffer[:self._params.audio_frame_size],
sample_rate=self._params.audio_out_sample_rate, sample_rate=self._params.audio_out_sample_rate,
num_channels=self._params.audio_out_channels num_channels=self._params.audio_out_channels
) )
@@ -159,7 +159,7 @@ class WebsocketServerOutputTransport(BaseOutputTransport):
if proto: if proto:
await self._websocket.send(proto) await self._websocket.send(proto)
self._audio_buffer = self._audio_buffer[self._params.audio_frame_size:] self._websocket_audio_buffer = self._websocket_audio_buffer[self._params.audio_frame_size:]
class WebsocketServerTransport(BaseTransport): class WebsocketServerTransport(BaseTransport):