From 2eb2c5a413c1e45c193971a60bf55d0b83dcfbe5 Mon Sep 17 00:00:00 2001 From: Brian Mathiyakom Date: Fri, 30 May 2025 16:35:54 -0700 Subject: [PATCH] Use `disconnect()` because `close()` doesn't exist SmallWebRTCConnection doesn't have a `close()`. There's a `_close()` but I assume that's private due to its naming. The closest function that uses `_close()` is `disconnect()`. I assume then, that the intended resource freeing function call should be to `disconnect()`. --- examples/foundational/04-transports-small-webrtc.py | 2 +- examples/p2p-webrtc/daily-interop-bridge/server.py | 2 +- examples/p2p-webrtc/video-transform/server/server.py | 2 +- examples/p2p-webrtc/voice-agent/server.py | 2 +- src/pipecat/examples/run.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/foundational/04-transports-small-webrtc.py b/examples/foundational/04-transports-small-webrtc.py index c70b566d4..627c13ad1 100644 --- a/examples/foundational/04-transports-small-webrtc.py +++ b/examples/foundational/04-transports-small-webrtc.py @@ -156,7 +156,7 @@ async def offer(request: dict, background_tasks: BackgroundTasks): @asynccontextmanager async def lifespan(app: FastAPI): yield # Run app - coros = [pc.close() for pc in pcs_map.values()] + coros = [pc.disconnect() for pc in pcs_map.values()] await asyncio.gather(*coros) pcs_map.clear() diff --git a/examples/p2p-webrtc/daily-interop-bridge/server.py b/examples/p2p-webrtc/daily-interop-bridge/server.py index 0025b3490..c8dae7888 100644 --- a/examples/p2p-webrtc/daily-interop-bridge/server.py +++ b/examples/p2p-webrtc/daily-interop-bridge/server.py @@ -74,7 +74,7 @@ async def offer(request: dict, background_tasks: BackgroundTasks): @asynccontextmanager async def lifespan(app: FastAPI): yield # Run app - coros = [pc.close() for pc in pcs_map.values()] + coros = [pc.disconnect() for pc in pcs_map.values()] await asyncio.gather(*coros) pcs_map.clear() diff --git a/examples/p2p-webrtc/video-transform/server/server.py b/examples/p2p-webrtc/video-transform/server/server.py index 0025b3490..c8dae7888 100644 --- a/examples/p2p-webrtc/video-transform/server/server.py +++ b/examples/p2p-webrtc/video-transform/server/server.py @@ -74,7 +74,7 @@ async def offer(request: dict, background_tasks: BackgroundTasks): @asynccontextmanager async def lifespan(app: FastAPI): yield # Run app - coros = [pc.close() for pc in pcs_map.values()] + coros = [pc.disconnect() for pc in pcs_map.values()] await asyncio.gather(*coros) pcs_map.clear() diff --git a/examples/p2p-webrtc/voice-agent/server.py b/examples/p2p-webrtc/voice-agent/server.py index b2ee0b4cd..f442333bf 100644 --- a/examples/p2p-webrtc/voice-agent/server.py +++ b/examples/p2p-webrtc/voice-agent/server.py @@ -69,7 +69,7 @@ async def serve_index(): @asynccontextmanager async def lifespan(app: FastAPI): yield # Run app - coros = [pc.close() for pc in pcs_map.values()] + coros = [pc.disconnect() for pc in pcs_map.values()] await asyncio.gather(*coros) pcs_map.clear() diff --git a/src/pipecat/examples/run.py b/src/pipecat/examples/run.py index d999a5b09..117ca285d 100644 --- a/src/pipecat/examples/run.py +++ b/src/pipecat/examples/run.py @@ -142,7 +142,7 @@ def run_example_webrtc( @asynccontextmanager async def lifespan(app: FastAPI): yield # Run app - coros = [pc.close() for pc in pcs_map.values()] + coros = [pc.disconnect() for pc in pcs_map.values()] await asyncio.gather(*coros) pcs_map.clear()