wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2699 from pipecat-ai/aleix/daily-on-before-leave

Browse Source 
DailyTransport: rename on_before_leave to on_before_disconnect
This commit is contained in:
Aleix Conchillo Flaqué
2025-09-19 20:38:46 -07:00
committed by GitHub
parent 7cb5c951f4 b1551b0d6b
commit 2289409b4c
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
CHANGELOG.md
View File

@@ -9,8 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added ### Added
- Added `on_before_disconnect` synchronous event to `DailyTransport` and - Added `on_before_leave` synchronous event to `DailyTransport`.
`LiveKitTransport`.
- Added `on_before_disconnect` synchronous event to `LiveKitTransport`.
- It is now possible to register synchronous event handlers. By default, all - It is now possible to register synchronous event handlers. By default, all
event handlers are executed in a separate task. However, in some cases we want event handlers are executed in a separate task. However, in some cases we want
@@ -36,7 +37,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
... ...
``` ```
- Added support for new RTVI `send-text` event, along with the ability to toggle the audio response off (skip tts) while handling the new context. - Added support for new RTVI `send-text` event, along with the ability to toggle
the audio response off (skip tts) while handling the new context.
### Changed ### Changed
@@ -65,7 +67,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`on_pipeline_cancelled` are now deprecated. Use `on_pipeline_finished` `on_pipeline_cancelled` are now deprecated. Use `on_pipeline_finished`
instead. instead.
- Support for the RTVI `append-to-context` event, in lieu of the new `send-text` event and making way for future events like `send-image`. - Support for the RTVI `append-to-context` event, in lieu of the new `send-text`
event and making way for future events like `send-image`.
### Fixed ### Fixed

4
src/pipecat/transports/daily/transport.py
View File

@@ -1973,7 +1973,7 @@ class DailyTransport(BaseTransport):
self._register_event_handler("on_recording_started") self._register_event_handler("on_recording_started")
self._register_event_handler("on_recording_stopped") self._register_event_handler("on_recording_stopped")
self._register_event_handler("on_recording_error") self._register_event_handler("on_recording_error")
self._register_event_handler("on_before_disconnect", sync=True) self._register_event_handler("on_before_leave", sync=True)
# Deprecated # Deprecated
self._register_event_handler("on_joined") self._register_event_handler("on_joined")
self._register_event_handler("on_left") self._register_event_handler("on_left")
@@ -2230,7 +2230,7 @@ class DailyTransport(BaseTransport):
async def _on_before_leave(self): async def _on_before_leave(self):
"""Handle before leave room events.""" """Handle before leave room events."""
await self._call_event_handler("on_before_disconnect") await self._call_event_handler("on_before_leave")
async def _on_error(self, error): async def _on_error(self, error):
"""Handle error events and push error frames.""" """Handle error events and push error frames."""