wx44wx/pipecat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a race condition in FastAPIWebsocketClient that occurred when attempting to send a message while the client was disconnecting.

Browse Source
This commit is contained in:
Filipi Fuchter
2025-07-30 18:07:40 -03:00
parent efb24071d5
commit 0c6e12a9b0
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@@ -97,6 +97,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed a race condition in `FastAPIWebsocketClient` that occurred when attempting to
send a message while the client was disconnecting.
- Fixed an issue in `GoogleLLMService` where interruptions did not work when an - Fixed an issue in `GoogleLLMService` where interruptions did not work when an
interruption strategy was used. interruption strategy was used.

15
src/pipecat/transports/network/fastapi_websocket.py
View File

@@ -132,8 +132,11 @@ class FastAPIWebsocketClient:
f"{self} exception sending data: {e.__class__.__name__} ({e}), application_state: {self._websocket.application_state}" f"{self} exception sending data: {e.__class__.__name__} ({e}), application_state: {self._websocket.application_state}"
) )
# For some reason the websocket is disconnected, and we are not able to send data # For some reason the websocket is disconnected, and we are not able to send data
# So let's properly handle it and disconnect the transport # So let's properly handle it and disconnect the transport if it is not already disconnecting
if self._websocket.application_state == WebSocketState.DISCONNECTED: if (
self._websocket.application_state == WebSocketState.DISCONNECTED
and not self.is_closing
):
logger.warning("Closing already disconnected websocket!") logger.warning("Closing already disconnected websocket!")
self._closing = True self._closing = True
await self.trigger_client_disconnected() await self.trigger_client_disconnected()
@@ -146,8 +149,12 @@ class FastAPIWebsocketClient:
if self.is_connected and not self.is_closing: if self.is_connected and not self.is_closing:
self._closing = True self._closing = True
await self._websocket.close() try:
await self.trigger_client_disconnected() await self._websocket.close()
except Exception as e:
logger.error(f"{self} exception while closing the websocket: {e}")
finally:
await self.trigger_client_disconnected()
async def trigger_client_disconnected(self): async def trigger_client_disconnected(self):
"""Trigger the client disconnected callback.""" """Trigger the client disconnected callback."""