From 0032594f214b1e2799f9d6e2ff40c046a4159e9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Date: Thu, 8 Aug 2024 22:04:22 -0700 Subject: [PATCH] transports(daily): fixed create_room expirations Fixes #348 --- CHANGELOG.md | 3 +++ src/pipecat/transports/services/helpers/daily_rest.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f285bc014..890a734ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fixed and issue with `DailyRESTHelper.create_room()` expirations which would + cause this function to stop working after the initial expiration elapsed. + - Improved `EndFrame` and `CancelFrame` handling. `EndFrame` should end things gracefully while a `CancelFrame` should cancel all running tasks as soon as possible. diff --git a/src/pipecat/transports/services/helpers/daily_rest.py b/src/pipecat/transports/services/helpers/daily_rest.py index fd47e939f..840222290 100644 --- a/src/pipecat/transports/services/helpers/daily_rest.py +++ b/src/pipecat/transports/services/helpers/daily_rest.py @@ -47,7 +47,7 @@ class DailyRoomProperties(BaseModel, extra="allow"): class DailyRoomParams(BaseModel): name: Optional[str] = None privacy: Literal['private', 'public'] = "public" - properties: DailyRoomProperties = DailyRoomProperties() + properties: DailyRoomProperties = Field(default_factory=DailyRoomProperties) class DailyRoomObject(BaseModel):